-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tag_pileup_frequency test fixes #2727
Conversation
…erated output file names in tool config test name attribute - test coverage still good.
@@ -64,12 +64,8 @@ java -jar '$__tool_directory__/TagPileup.jar' | |||
<param name="proper_pe" value="false" /> | |||
<param name="combine_strands" value="0" /> | |||
<param name="composite_smoothing_window" value="0" /> | |||
<param name="output_heatmap" value="true" /> | |||
<param name="output_heatmap" value="false" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I give this a go ? I assume this test used to work prior to isolating the upload paths.
I suspect this will always generate not very user-friendly names in the collections (dataset_<dataset_id>
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please give it a go - I'd love to see how this should work! ;) Thanks for the help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output naming convention for heatmap ouitput collection elements is something like __read1_anti.tabular
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test that also outputs the heatmaps in order to see if the updated requirements work.
…ally generated output file names in tool config test name attribute - test coverage still good." This reverts commit 6040fcd.
@@ -64,12 +64,8 @@ java -jar '$__tool_directory__/TagPileup.jar' | |||
<param name="proper_pe" value="false" /> | |||
<param name="combine_strands" value="0" /> | |||
<param name="composite_smoothing_window" value="0" /> | |||
<param name="output_heatmap" value="true" /> | |||
<param name="output_heatmap" value="false" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test that also outputs the heatmaps in order to see if the updated requirements work.
@bernt-matthias I've restored the test, but it does look like this tool doesn't do any plotting (only tabullar outputs). I'll see if it passes without the fonts as well. |
Yep, works fine without the fonts. |
tag_pileup_frequency test fixes
FOR CONTRIBUTOR: