Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bioperl testing #642

Merged
merged 3 commits into from
Jun 18, 2016
Merged

bioperl testing #642

merged 3 commits into from
Jun 18, 2016

Conversation

bgruening
Copy link
Member

No description provided.

@hexylena
Copy link
Member

hexylena commented Mar 6, 2016

Can't locate LWP/UserAgent.pm in @.INC (you may need to install the LWP::UserAgent module) (

????

That should be part of the bioperl dep tree?

@bgruening
Copy link
Member Author

It's not at least not in bioconda. It tried to work on this but it is a huge pain as it touches millions of perl deps: https://github.com/bioconda/bioconda-recipes/compare/perl_html?expand=1

@hexylena
Copy link
Member

hexylena commented Mar 6, 2016

woah. Yuck. :( what to do about this?

@bgruening
Copy link
Member Author

I guess I need to fix the conda package. But this will take some time.

@bgruening
Copy link
Member Author

Btw. @erasche I would be fine to put all tools automatically to all TS that are under conda testing. What do you think?

@hexylena
Copy link
Member

hexylena commented Mar 6, 2016

@bgruening absolutely, tests pass = should be in TS, in my opinion. If it's on master, we've all agreed we're happy with the software.

@bgruening
Copy link
Member Author

bgruening commented Jun 18, 2016

This is for Eric! He probably knows what this means for JBrowse :)

@erasche I needed to change the test data.
I will leave this to you to merge, as the conda version is different from the TS version.

@hexylena hexylena self-assigned this Jun 18, 2016
@@ -23,6 +23,7 @@
<environment_variable name="BOOST_ROOT_DIR" action="set_to">$INSTALL_DIR/boost</environment_variable>
<environment_variable action="prepend_to" name="LD_LIBRARY_PATH">$INSTALL_DIR/boost/lib/</environment_variable>
<environment_variable action="prepend_to" name="LIBRARY_PATH">$INSTALL_DIR/boost/lib/</environment_variable>
<environment_variable action="prepend_to" name="LIBRARY_PATH">$INSTALL_DIR/boost/lib/</environment_variable>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a duplicate of the above line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is here in first place? Bad rebase? Will fix it.

@hexylena
Copy link
Member

@bgruening <3 <3 <3

That changed test data looks fine to me.

@bgruening
Copy link
Member Author

Your welcome @erasche! :)
I fixed that one liner.

@hexylena hexylena merged commit 3dd4c82 into master Jun 18, 2016
@bgruening bgruening deleted the bp branch October 29, 2016 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants