Skip to content

Commit

Permalink
feat: support name.resolve of peerid as cid (ipfs#1145)
Browse files Browse the repository at this point in the history
* feat: support name.resolve of peerid as cid

This is a hacky way to support CIDs when API is go-ipfs 0.4.22 or older
(convert toBase58btc before sending)

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
  • Loading branch information
lidel authored and Alan Shaw committed Nov 7, 2019
1 parent 4acd43e commit 2d9afc8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"browser-process-platform": "~0.1.1",
"cross-env": "^6.0.0",
"go-ipfs-dep": "^0.4.22",
"interface-ipfs-core": "^0.117.2",
"interface-ipfs-core": "^0.118.0",
"ipfsd-ctl": "^0.47.1",
"nock": "^11.4.0",
"stream-equal": "^1.1.1"
Expand Down
10 changes: 9 additions & 1 deletion test/interface.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,15 @@ describe('interface-ipfs-core tests', () => {
spawnOptions: {
args: ['--offline']
}
}))
}), {
skip: [
// stop
{
name: 'should resolve a record from peerid as cidv1 in base32',
reason: 'TODO not implemented in go-ipfs yet: https://github.com/ipfs/go-ipfs/issues/5287'
}
]
})

// TODO: uncomment after https://github.com/ipfs/interface-ipfs-core/pull/361 being merged and a new release
tests.namePubsub(CommonFactory.create({
Expand Down

0 comments on commit 2d9afc8

Please sign in to comment.