Should specify which link didn't exist on ipfs.cat

[daviddias]

https://github.com/ipfs/js-ipfs/blob/master/src/core/components/files.js#L140 should report the same error as js-ipfs-api.

Example: ipfs-inactive/interface-js-ipfs-core#183 (comment)

//cc @pgte

[daviddias]

The HTTP API didn't get updated

  1) HTTP API
       ## interface-ipfs-core over ipfs-api
         .files
           .cat
             errors on unknown path:
     AssertionError: expected 'Failed to cat file: Error: No such file' to be one of [ Array(2) ]
      at ipfs.files.cat.catch (node_modules/interface-ipfs-core/src/files.js:439:36)
      at <anonymous>
      at process._tickDomainCallback (internal/process/next_tick.js:228:7)

[vs77bb]

@diasdavid Hi, Vivek from Gitcoin here. Is this something which might be helpful for us to bounty to get some developer eyes on it? We're a big fan of IPFS and would love to contribute, if helpful! Let us know if another issue is even more helpful (cc @owocki)

[youngnicks]

I'm new to ipfs, but am willing to give this a shot. It looks like it is just changing the error message in src/core/components/files.js from 'No such file' to no link named "${fileName}" under ${path}. Is this correct?

[youngnicks]

If the above is true, should the ipfs/interface-ipfs-core be updated to remove No such file as a valid scenario? The test also fails due to the test looking for the error message thrown in files.cat, however, Failed to cat file: is prepended to the error message. I see other tests use expect(err.message).to.contain instead of expect(err.message).to.oneOf.

expect(err.message).to.contain(
  'no link named "does-not-exist" under Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP'
)

[niinpatel]

Is this still open? Can I look into this?

[achingbrain]

Closing as this issue is very stale.