Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stackable/ blocks support for get_the_excerpt API #1414

Merged
merged 7 commits into from
Aug 4, 2021
Merged

Add stackable/ blocks support for get_the_excerpt API #1414

merged 7 commits into from
Aug 4, 2021

Conversation

blankart
Copy link
Contributor

@blankart blankart commented Jul 30, 2021 •
edited
Loading

This was linked to issues Jul 30, 2021
contents of advanced text not being displayed in get_the_excerpt() #1123
Closed
Adding stackable block inside a post shows the code of the block in the excerpt in Editor #1271
Closed
@blankart blankart added [version] V3 enhancement New feature or request PR: Needs Review This PR needs to be reviewed labels Jul 30, 2021
@blankart blankart changed the title [V3] Add stackable/ blocks support for get_the_excerpt API Add stackable/ blocks support for get_the_excerpt API Jul 30, 2021
bfintal
bfintal requested changes Jul 31, 2021
View reviewed changes
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see some of my comments in #1413

To make v3 and v2 code separated:

  • keep all the stackable/* blocks in src/blocks.php, then
  • all the old ugb/* blocks, move to src/deprecated/v2/blocks.php
    • to make things easily searchable, the v2 code, use the function names excerpt_allowed_wrapper_blocks_v2 and stackable_add_excerpt_blocks_v2

@bfintal bfintal added PR: Good to Merge This PR is approved and can be merged PR: Reviewed w/ Comments This PR has been reviewed and has comments that need to be resolved and removed PR: Needs Review This PR needs to be reviewed PR: Good to Merge This PR is approved and can be merged labels Jul 31, 2021
@blankart
Copy link
Contributor Author

blankart commented Aug 2, 2021

I haven't tested my recent commit yet. I am getting a build error in v3 branch:

pro__premium_only

Error: PostCSS plugin autoprefixer requires PostCSS 8

Will mark as ready for review once this is resolved.

@blankart blankart marked this pull request as draft August 2, 2021 06:07
@blankart blankart added PR: Needs Review This PR needs to be reviewed and removed PR: Reviewed w/ Comments This PR has been reviewed and has comments that need to be resolved labels Aug 2, 2021
@blankart blankart marked this pull request as ready for review August 2, 2021 07:20
bfintal
bfintal requested changes Aug 2, 2021
View reviewed changes
src/blocks.php Outdated Show resolved Hide resolved
@bfintal bfintal added PR: Reviewed w/ Comments This PR has been reviewed and has comments that need to be resolved and removed PR: Needs Review This PR needs to be reviewed labels Aug 2, 2021
@blankart blankart added PR: Needs Review This PR needs to be reviewed and removed PR: Reviewed w/ Comments This PR has been reviewed and has comments that need to be resolved labels Aug 2, 2021
@bfintal bfintal merged commit 300f669 into v3 Aug 4, 2021
@bfintal bfintal deleted the v3-get-the-excerpt-support branch August 4, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfintal bfintal bfintal requested changes

Assignees
No one assigned
Labels
enhancement New feature or request PR: Needs Review This PR needs to be reviewed [version] V3
Projects
None yet
Milestone
No milestone
2 participants
@blankart @bfintal