Misc Improvements and Bug Fixes #206
Conversation
…sed on PR workflow and merge into test workflow.
…-hub to remove error spam, improve error checking on windows image installs
|
|
| @@ -16,8 +16,11 @@ RUN sh -c 'echo "deb https://hub.unity3d.com/linux/repos/deb stable main" > /etc | |||
| && apt-get -q install -y "unityhub=$hubVersion" \ | |||
| && apt-get clean | |||
|
|
|||
| # Bug in xvfb-run that causes it to redirect stderr to stdout. We want it separate | |||
There was a problem hiding this comment.
Do you have details about that bug? (Just curious). Maybe it's worth linking to the bug and its details
There was a problem hiding this comment.
|
The following two jobs both failed with a timeout, but everything else is green. https://github.com/game-ci/docker/actions/runs/4675713024/jobs/8286515438?pr=206 Are we ok with that? |
|
I checked the timeouts and they are from Unity not exiting despite completing the build successfully in well under 15 minutes. This is a known issue but out of scope for this PR so it is acceptable. The images themselves are building and installing the correct modules which is the main thing that matters for the scope of this PR. |
# Conflicts: # .github/workflows/new-ubuntu-base-image-requested.yml # .github/workflows/new-ubuntu-hub-image-requested.yml # .github/workflows/new-ubuntu-legacy-editor-image-requested.yml # .github/workflows/new-ubuntu-post-2019-2-editor-image-requested.yml # .github/workflows/new-windows-base-image-requested.yml # .github/workflows/new-windows-hub-image-requested.yml # .github/workflows/new-windows-legacy-editor-image-requested.yml # .github/workflows/new-windows-post-2019-2-editor-image-requested.yml # .github/workflows/test.yml # images/windows/editor/Dockerfile
Changes
Checklist