Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Improvements and Bug Fixes #206

Merged
merged 28 commits into from
Apr 12, 2023
Merged

Misc Improvements and Bug Fixes #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a943d03
Add additional tests for windows platforms. Remove duplicate tests ba…
AndrewKahr Apr 10, 2023
940efbe
Update naming scheme. Fix jq code
AndrewKahr Apr 10, 2023
38cfbfb
Update jq code
AndrewKahr Apr 10, 2023
dcd9a24
Test windows image builds. Expand workspace size on windows
AndrewKahr Apr 10, 2023
3e87423
Fix docker save running slowly on Windows
AndrewKahr Apr 10, 2023
b883be8
Exclude non il2cpp base Windows build, fix incorrect shell, use unity…
AndrewKahr Apr 10, 2023
b58a9ef
Revert relying on unity-hub error code, pipe stderr to null for unity…
AndrewKahr Apr 11, 2023
d46cd8b
Exclude uwp on 2018.
AndrewKahr Apr 11, 2023
9b8038c
Remove symlink setup. Reintroduce saved base/hub image for windows
AndrewKahr Apr 11, 2023
0887542
Reimplement junction backing for artifact generation on windows
AndrewKahr Apr 11, 2023
d07584c
Fix missing variable
AndrewKahr Apr 11, 2023
5663eaf
Fix artifact pathing
AndrewKahr Apr 11, 2023
f3a41fb
Debug print
AndrewKahr Apr 11, 2023
ed7f672
Fix artifact pathing
AndrewKahr Apr 11, 2023
2eabb56
More debug
AndrewKahr Apr 11, 2023
8892e6c
Move symlink setup after checkout
AndrewKahr Apr 11, 2023
c2f25e7
Change artifact path for windows
AndrewKahr Apr 11, 2023
8f22b7a
Create artifact folder
AndrewKahr Apr 11, 2023
63ffa01
Test zstd compression
AndrewKahr Apr 11, 2023
09c3abe
Fix compression pathing
AndrewKahr Apr 11, 2023
a78a56d
use zstd -d
AndrewKahr Apr 11, 2023
26ecaa5
better compression level, fix missing $, add debug print
AndrewKahr Apr 11, 2023
f81ccda
fix workspace pathing
AndrewKahr Apr 11, 2023
9a720f4
Fix github output variable
AndrewKahr Apr 11, 2023
13e4afa
Checkout latest tag rather than latest commit to main
AndrewKahr Apr 11, 2023
97321fd
Exclude unstable unity versions. Add timeouts to steps
AndrewKahr Apr 12, 2023
601b6b2
Cleanup debug
AndrewKahr Apr 12, 2023
92412e0
Exclude unstable unity versions, reduce timeouts
AndrewKahr Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/new-ubuntu-base-image-requested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Checkout latest release tag
run: |
LATEST_TAG=$(git describe --tags `git rev-list --tags --max-count=1`)
git checkout $LATEST_TAG

#################
# Variables #
#################
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/new-ubuntu-hub-image-requested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Checkout latest release tag
run: |
LATEST_TAG=$(git describe --tags `git rev-list --tags --max-count=1`)
git checkout $LATEST_TAG

#################
# Variables #
#################
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/new-ubuntu-legacy-editor-image-requested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Checkout latest release tag
run: |
LATEST_TAG=$(git describe --tags `git rev-list --tags --max-count=1`)
git checkout $LATEST_TAG

#################
# Variables #
#################
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/new-ubuntu-post-2019-2-editor-image-requested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Checkout latest release tag
run: |
LATEST_TAG=$(git describe --tags `git rev-list --tags --max-count=1`)
git checkout $LATEST_TAG

#################
# Variables #
#################
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/new-windows-base-image-requested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Checkout latest release tag
run: |
LATEST_TAG=$(git describe --tags `git rev-list --tags --max-count=1`)
git checkout $LATEST_TAG
shell: bash

#################
# Variables #
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/new-windows-hub-image-requested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Checkout latest release tag
run: |
LATEST_TAG=$(git describe --tags `git rev-list --tags --max-count=1`)
git checkout $LATEST_TAG
shell: bash

#################
# Variables #
Expand Down
32 changes: 20 additions & 12 deletions .github/workflows/new-windows-legacy-editor-image-requested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,15 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Checkout latest release tag
run: |
LATEST_TAG=$(git describe --tags `git rev-list --tags --max-count=1`)
git checkout $LATEST_TAG
shell: bash

#################
# Variables #
#################
Expand All @@ -59,21 +67,21 @@ jobs:
if ("${{ github.event.inputs.jobId }}")
{
# Workflow Dispatch
echo "jobId=${{ github.event.inputs.jobId }}" >> $GITHUB_ENV
echo "editorVersion=${{ github.event.inputs.editorVersion }}" >> $GITHUB_ENV
echo "changeSet=${{ github.event.inputs.changeSet }}" >> $GITHUB_ENV
echo "repoVersionFull=${{ github.event.inputs.repoVersionFull }}" >> $GITHUB_ENV
echo "repoVersionMinor=${{ github.event.inputs.repoVersionMinor }}" >> $GITHUB_ENV
echo "repoVersionMajor=${{ github.event.inputs.repoVersionMajor }}" >> $GITHUB_ENV
echo "jobId=${{ github.event.inputs.jobId }}" >> $GITHUB_OUTPUT
echo "editorVersion=${{ github.event.inputs.editorVersion }}" >> $GITHUB_OUTPUT
echo "changeSet=${{ github.event.inputs.changeSet }}" >> $GITHUB_OUTPUT
echo "repoVersionFull=${{ github.event.inputs.repoVersionFull }}" >> $GITHUB_OUTPUT
echo "repoVersionMinor=${{ github.event.inputs.repoVersionMinor }}" >> $GITHUB_OUTPUT
echo "repoVersionMajor=${{ github.event.inputs.repoVersionMajor }}" >> $GITHUB_OUTPUT
} else
{
# Repo Dispatch
echo "jobId=${{ github.event.client_payload.jobId }}" >> $GITHUB_ENV
echo "editorVersion=${{ github.event.client_payload.editorVersion }}" >> $GITHUB_ENV
echo "changeSet=${{ github.event.client_payload.changeSet }}" >> $GITHUB_ENV
echo "repoVersionFull=${{ github.event.client_payload.repoVersionFull }}" >> $GITHUB_ENV
echo "repoVersionMinor=${{ github.event.client_payload.repoVersionMinor }}" >> $GITHUB_ENV
echo "repoVersionMajor=${{ github.event.client_payload.repoVersionMajor }}" >> $GITHUB_ENV
echo "jobId=${{ github.event.client_payload.jobId }}" >> $GITHUB_OUTPUT
echo "editorVersion=${{ github.event.client_payload.editorVersion }}" >> $GITHUB_OUTPUT
echo "changeSet=${{ github.event.client_payload.changeSet }}" >> $GITHUB_OUTPUT
echo "repoVersionFull=${{ github.event.client_payload.repoVersionFull }}" >> $GITHUB_OUTPUT
echo "repoVersionMinor=${{ github.event.client_payload.repoVersionMinor }}" >> $GITHUB_OUTPUT
echo "repoVersionMajor=${{ github.event.client_payload.repoVersionMajor }}" >> $GITHUB_OUTPUT
}

- name: Show hook input
Expand Down
32 changes: 20 additions & 12 deletions .github/workflows/new-windows-post-2019-2-editor-image-requested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Checkout latest release tag
run: |
LATEST_TAG=$(git describe --tags `git rev-list --tags --max-count=1`)
git checkout $LATEST_TAG
shell: bash

#################
# Variables #
Expand All @@ -60,21 +68,21 @@ jobs:
if ("${{ github.event.inputs.jobId }}")
{
# Workflow Dispatch
echo "jobId=${{ github.event.inputs.jobId }}" >> $GITHUB_ENV
echo "editorVersion=${{ github.event.inputs.editorVersion }}" >> $GITHUB_ENV
echo "changeSet=${{ github.event.inputs.changeSet }}" >> $GITHUB_ENV
echo "repoVersionFull=${{ github.event.inputs.repoVersionFull }}" >> $GITHUB_ENV
echo "repoVersionMinor=${{ github.event.inputs.repoVersionMinor }}" >> $GITHUB_ENV
echo "repoVersionMajor=${{ github.event.inputs.repoVersionMajor }}" >> $GITHUB_ENV
echo "jobId=${{ github.event.inputs.jobId }}" >> $GITHUB_OUTPUT
echo "editorVersion=${{ github.event.inputs.editorVersion }}" >> $GITHUB_OUTPUT
echo "changeSet=${{ github.event.inputs.changeSet }}" >> $GITHUB_OUTPUT
echo "repoVersionFull=${{ github.event.inputs.repoVersionFull }}" >> $GITHUB_OUTPUT
echo "repoVersionMinor=${{ github.event.inputs.repoVersionMinor }}" >> $GITHUB_OUTPUT
echo "repoVersionMajor=${{ github.event.inputs.repoVersionMajor }}" >> $GITHUB_OUTPUT
} else
{
# Repo Dispatch
echo "jobId=${{ github.event.client_payload.jobId }}" >> $GITHUB_ENV
echo "editorVersion=${{ github.event.client_payload.editorVersion }}" >> $GITHUB_ENV
echo "changeSet=${{ github.event.client_payload.changeSet }}" >> $GITHUB_ENV
echo "repoVersionFull=${{ github.event.client_payload.repoVersionFull }}" >> $GITHUB_ENV
echo "repoVersionMinor=${{ github.event.client_payload.repoVersionMinor }}" >> $GITHUB_ENV
echo "repoVersionMajor=${{ github.event.client_payload.repoVersionMajor }}" >> $GITHUB_ENV
echo "jobId=${{ github.event.client_payload.jobId }}" >> $GITHUB_OUTPUT
echo "editorVersion=${{ github.event.client_payload.editorVersion }}" >> $GITHUB_OUTPUT
echo "changeSet=${{ github.event.client_payload.changeSet }}" >> $GITHUB_OUTPUT
echo "repoVersionFull=${{ github.event.client_payload.repoVersionFull }}" >> $GITHUB_OUTPUT
echo "repoVersionMinor=${{ github.event.client_payload.repoVersionMinor }}" >> $GITHUB_OUTPUT
echo "repoVersionMajor=${{ github.event.client_payload.repoVersionMajor }}" >> $GITHUB_OUTPUT
}

- name: Show hook input
Expand Down
Loading