Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify environment support #36

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Clarify environment support #36

merged 2 commits into from
Feb 15, 2022

Conversation

samanpwbb
Copy link
Contributor

Changes

Clarify environment support. A quick read of the bash script makes this point kind of obvious, but it took me a bit of trial and error to get there 😂 - this should save others some time in the future. Would be great to get cross-platform support eventually, but I think this would be a wise stopgap.

Refs #34 and #35

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link
Member

@davidmfinol davidmfinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR; I think this is a good note to have until we are able to support other platforms.

@davidmfinol davidmfinol merged commit 66737cc into game-ci:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants