Ganglia GPU Monitoring Enhancements #243
Conversation
ranacseruet
commented
Aug 5, 2014
ranacseruet
commented
- This aims to generalize the number of custom php graph files required to represent custom metric graphs. This eliminates the limit of hard coded number of GPUs ganglia-web can handle.
No need to %__cp %SOURCE1 as well. More over, using more than one source prevent a build from tarball using rpmbuild -tb ganglia-web-3.5.12.tar.gz for instance.
…in the same installation whatever the build is (manual, deb pkg or rpm pkg) - Use Makefile to make install for deb and rpm as well including config files. - Include specfile in the dist-gzip so a rpmbuild -tb (tarbuild) can be used - Added customization for rpmbuild using --with tags (see spec file for usage and more details). - Use adequate default values for rpm. The apache_user is not www-data. it's apache... - Use /etc/ganglia-webfrontend to store conf.php what ever the distro is. Make sure that a link is set to apache config dir using triggers or postinstall. - Use /etc/ganglia-webfrontend to store conf.php what ever the distro is. Use a generic conf.php in /usr/share/ganglia-webfrontend to load the file from /etc/ganglia-webfrontend. - Replaced vargwebstatedir with vargwebdir in conf_default.php.in and Makefile. - filters dir was not created under debian pkg or manual make install - Added possibility to have a httpd_group different from user. For instance you can choose to install files under apache.daemon identity. If not specified, a group with the same name as the user is used. - Added comment in the install section of the Makefile so it's clear. - Reworked dist-gzip target so version.php and spec file are generated while other .in files remain so they can be tuned by make or make install. - Make sure that sharedstatedir is not owned by rpm package (conflict on fc-18+), and updated %file section accordingly. - Removed the manual install and specific config files in debian packaging. Using standard make install DESTDIR=...
Get upstream changes.
… adapted specfile for this. Now Makefile has a rule that install files without setting ownership. this permit to build an rpm without being root. using --define magro for specfile tunning.
|
Before, for cluster node with more than one gpus, custom graph for a metric(say ‘util’) had to be named as gpu0_util.php, gpu1_util.php, gpu2_util.php , which was limited to the hard coded numbers added up to. Thus, to make this process simpler, I have added an small modification under ‘ganglia-web’ module, which shouldn’t effect any additional functionality, but facilitate this particular issue to all other modules(which could have multiple device attached in single node) as well |
|
@vvuksan do you think this is OK to merge? It is not a very big change. |
…ic graphs and reports. This is accomplished by specifying a tz query parameter to the ganaglia-web url. The timezone parameter takes the standard Linux form, e.g. tz=UTC, tz=America/New_York
|
@ranacseruet can you please contact @vvuksan on IRC to see if he is happy to merge this? I already accepted the other pull request. |
Reworked the install and packaging so it results in the same installation whatever the build is (manual, deb pkg or rpm pkg)
|
Problem I have with this is that it relies on optional graph name having a number in it so if for example someone calls their graphs apache2.2_report it may get caught. I would prefer we implement this differently. We should do this in the actual optional graph config and not in graph.php. There is no reason why you shouldn't be able to traverse the RRD directory to find out all the GPU names and numbers |
Use jstz to determine browser timezone. In the future my hope is that we can do this with the moment library.
Some cleanup work in the area of date/time manipulation.
…ression to allow for hyphens.
…ly display the "now" button if the gweb timezone is set to "browser"
Added the capability to control the timezone used to display rrd metric graphs
Lock the cache file while writing to prevent partial reads
No need to fold since gmetad returns upper-case
|
@vvuksan , as per the design document that I shared earlier(http://goo.gl/kLeumX), I have modified the implementation, which reads mapping settings from json file. Please review this change. Also, if this is OK, to get the gpu module working, there will be a json file needed, which I will create pull request separately. You can review that json settings as well: http://goo.gl/MgHRfB . Thanks. |
Update ganglia master
Micro-optimize XML calls
|
I found it was showing some conflict due to recent other changes on master branch. Just merged the conflicts |
