Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve https://github.com/gap-system/gap/issues/5761 #153

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

james-d-mitchell
Copy link
Contributor

No description provided.

@fingolfin
Copy link
Member

Thank you! However, this also needs a change to PackageInfo.g to require a GAP version which supports the new functions, see e.g. gap-packages/orb#69

Please also update .github/workflows/CI.yml to remove the tests against older now unsupported GAP versions.

@james-d-mitchell
Copy link
Contributor Author

Thank you! However, this also needs a change to PackageInfo.g to require a GAP version which supports the new functions, see e.g. gap-packages/orb#69

Please also update .github/workflows/CI.yml to remove the tests against older now unsupported GAP versions.

datastructures already requires GAP-4.12, I made another mistake, hopefully fixed now.

@james-d-mitchell james-d-mitchell force-pushed the load-kernel-ext branch 2 times, most recently from bf87aa5 to b0bdb07 Compare August 26, 2024 13:44
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (ef1a0de) to head (d6934c0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          35       35           
  Lines        2696     2696           
  Branches      109      109           
=======================================
  Hits         2567     2567           
  Misses        109      109           
  Partials       20       20           

@fingolfin fingolfin merged commit 68bba98 into gap-packages:master Aug 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants