Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LoadKernelExtension and IsKernelExtensionAvailable in more packages #5761

Open
15 of 18 tasks
fingolfin opened this issue Jul 3, 2024 · 11 comments · Fixed by homalg-project/CddInterface#43 or gap-packages/io#125
Open
15 of 18 tasks

Comments

@fingolfin
Copy link
Member

fingolfin commented Jul 3, 2024

These function have been available since GAP 4.12.0 and I think we should use them in more (ideally all) packages with kernel extension. So far only edim and browse do so.

Here is a list of affected distributed packages. The goal would be to either submit an issue or a PR to each of these over time.

@james-d-mitchell
Copy link
Contributor

Some of us at GAPDays are going to work on this today.

@Joseph-Edwards
Copy link
Contributor

I'm going to make a start on semigroups

@limakzi
Copy link

limakzi commented Aug 26, 2024

I will take json.

@Joseph-Edwards
Copy link
Contributor

Working on cvec now.

james-d-mitchell added a commit to james-d-mitchell/curlInterface that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/datastructures that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/datastructures that referenced this issue Aug 26, 2024
@limakzi
Copy link

limakzi commented Aug 26, 2024

Working on orb.
gap-packages/orb#69

james-d-mitchell added a commit to james-d-mitchell/DeepThought that referenced this issue Aug 26, 2024
@Joseph-Edwards
Copy link
Contributor

Working on ferret.

@fingolfin
Copy link
Member Author

Thanks for the efforts, folks. A general comment: I think it is fine to just change all these packages to require GAP >= 4.12. After all: not many people will update a single package; most just update all of GAP at once. (This might change in the future if PackageManager gets more widely used but I don't think we are there yet, so we don't need to worry about it.

If you do it that way, then also update .github/workflows/CI.yml to not test against older (now unsupported) GAP versions.

@limakzi
Copy link

limakzi commented Aug 26, 2024

@fingolfin Lets take it as definition of done, if so.
I'm fully OK with that. By the way, working on gauss. ;)

Pull-request: homalg-project/homalg_project#614.

james-d-mitchell added a commit to james-d-mitchell/curlInterface that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/curlInterface that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/crypting that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/DeepThought that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/DeepThought that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/datastructures that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/DeepThought that referenced this issue Aug 26, 2024
@Joseph-Edwards
Copy link
Contributor

Doing float now

james-d-mitchell added a commit to james-d-mitchell/datastructures that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/ZeroMQInterface that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/datastructures that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/datastructures that referenced this issue Aug 26, 2024
james-d-mitchell added a commit to james-d-mitchell/ZeroMQInterface that referenced this issue Aug 26, 2024
@limakzi
Copy link

limakzi commented Aug 26, 2024

gap-packages/hap#123

markuspf pushed a commit to gap-packages/crypting that referenced this issue Aug 26, 2024
fingolfin pushed a commit to gap-packages/DeepThought that referenced this issue Aug 26, 2024
fingolfin pushed a commit to gap-packages/ZeroMQInterface that referenced this issue Aug 26, 2024
@fingolfin
Copy link
Member Author

Just to say: it might be a bit premature to mark a package as "fixed" in the list at the top of this issue right after the corresponding PR was merged: in my eyes it is only truly "fixed" if there also is a release of that package with the changes.

kamalsaleh added a commit to homalg-project/CddInterface that referenced this issue Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants