Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in testextra/grpperm.tst in master branch #3464

Closed
olexandr-konovalov opened this issue May 19, 2019 · 1 comment · Fixed by #3451
Closed

Errors in testextra/grpperm.tst in master branch #3464

olexandr-konovalov opened this issue May 19, 2019 · 1 comment · Fixed by #3451
Milestone
GAP 4.11.0

Comments

@olexandr-konovalov
Copy link
Member

See e.g. this St Andrews-only link:

########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-major-release-test/\
GAPCOPTS/64build/GAPTARGET/extra/label/kovacs/gap-4.11.0/tst/testextra/grpperm\
.tst:260
# Input is:
coh.cohomology;
# Expected output:
[ <an immutable GF2 vector of length 336>, <an immutable GF2 vector of length
    336> ]
# But found:
[ <an immutable GF2 vector of length 224>, <an immutable GF2 vector of length 
    224> ]
########
########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-major-release-test/\
GAPCOPTS/64build/GAPTARGET/extra/label/kovacs/gap-4.11.0/tst/testextra/grpperm\
.tst:264
# Input is:
p:=List(e,x->FpGroupCocycle(coh,x,true));
# Expected output:
[ <fp group of size 61440 on the generators [ F1, F2, F3, F4, F5, F6, F7, F8,
      m1, m2, m3, m4 ]>, <fp group of size 61440 on the generators
    [ F1, F2, F3, F4, F5, F6, F7, F8, m1, m2, m3, m4 ]>,
  <fp group of size 61440 on the generators [ F1, F2, F3, F4, F5, F6, F7, F8,
      m1, m2, m3, m4 ]>, <fp group of size 61440 on the generators
    [ F1, F2, F3, F4, F5, F6, F7, F8, m1, m2, m3, m4 ]> ]
# But found:
Error, Assertion failure
########
########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-major-release-test/\
GAPCOPTS/64build/GAPTARGET/extra/label/kovacs/gap-4.11.0/tst/testextra/grpperm\
.tst:271
# Input is:
p:=List(p,x->Image(IsomorphismPermGroup(x)));
# Expected output:
[ <permutation group of size 61440 with 12 generators>,
  <permutation group of size 61440 with 12 generators>,
  <permutation group of size 61440 with 12 generators>,
  <permutation group of size 61440 with 12 generators> ]
# But found:
Error, Variable: 'p' must have a value
########

In these three diffs we have:

  1. Different dimensions
  2. Assertion failure
  3. Caused by failed (2)
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone May 19, 2019
hulpke added a commit to hulpke/gap that referenced this issue May 20, 2019
@hulpke
Make test more robust. (Address gap-system#3464)
6cdaafe 
Test for running, n ot concrete output. Also change one assertion level
higher so that it is not triggered by the (arbitrarily chosen level of) the
automatic tests.
(This is safer than ad-hoc quickly changing complicated but stable code.)
This is a "be nice" assertion (that was never intended for automated tests),
not a must have.

This resolves gap-system#3464
@hulpke hulpke changed the title Errors in estextra/grpperm.tst in master branch Errors in testextra/grpperm.tst in master branch May 20, 2019
@hulpke
Copy link
Contributor

hulpke commented May 20, 2019

I have added changes to #3451 (which also impacts some of the output) that resolve these (all harmless, even the assertion) problems.

hulpke added a commit to hulpke/gap that referenced this issue May 20, 2019
@hulpke
Make test more robust. (Address gap-system#3464)
151e779 
Test for running, n ot concrete output. Also change one assertion level
higher so that it is not triggered by the (arbitrarily chosen level of) the
automatic tests.
(This is safer than ad-hoc quickly changing complicated but stable code.)
This is a "be nice" assertion (that was never intended for automated tests),
not a must have.

This resolves gap-system#3464
hulpke added a commit to hulpke/gap that referenced this issue May 21, 2019
@hulpke
Make test more robust. (Address gap-system#3464)
5659418 
Test for running, n ot concrete output. Also change one assertion level
higher so that it is not triggered by the (arbitrarily chosen level of) the
automatic tests.
(This is safer than ad-hoc quickly changing complicated but stable code.)
This is a "be nice" assertion (that was never intended for automated tests),
not a must have.

This resolves gap-system#3464
hulpke added a commit to hulpke/gap that referenced this issue May 22, 2019
@hulpke
Make test more robust. (Address gap-system#3464)
c6dfa44 
Test for running, n ot concrete output. Also change one assertion level
higher so that it is not triggered by the (arbitrarily chosen level of) the
automatic tests.
(This is safer than ad-hoc quickly changing complicated but stable code.)
This is a "be nice" assertion (that was never intended for automated tests),
not a must have.

This resolves gap-system#3464
hulpke added a commit to hulpke/gap that referenced this issue May 24, 2019
@hulpke
Make test more robust. (Address gap-system#3464)
9a225b4 
Test for running, n ot concrete output. Also change one assertion level
higher so that it is not triggered by the (arbitrarily chosen level of) the
automatic tests.
(This is safer than ad-hoc quickly changing complicated but stable code.)
This is a "be nice" assertion (that was never intended for automated tests),
not a must have.

This resolves gap-system#3464
hulpke added a commit to hulpke/gap that referenced this issue May 27, 2019
@hulpke
Make test more robust. (Address gap-system#3464)
52df9bc 
Test for running, n ot concrete output. Also change one assertion level
higher so that it is not triggered by the (arbitrarily chosen level of) the
automatic tests.
(This is safer than ad-hoc quickly changing complicated but stable code.)
This is a "be nice" assertion (that was never intended for automated tests),
not a must have.

This resolves gap-system#3464
@hulpke hulpke mentioned this issue May 28, 2019
Merged
hulpke added a commit to hulpke/gap that referenced this issue May 28, 2019
@hulpke
Make test more robust. (Address gap-system#3464)
060d324 
Test for running, n ot concrete output. Also change one assertion level
higher so that it is not triggered by the (arbitrarily chosen level of) the
automatic tests.
(This is safer than ad-hoc quickly changing complicated but stable code.)
This is a "be nice" assertion (that was never intended for automated tests),
not a must have.

This resolves gap-system#3464
hulpke added a commit to hulpke/gap that referenced this issue May 29, 2019
@hulpke
Make test more robust. (Address gap-system#3464)
2eed4f6 
Test for running, n ot concrete output. Also change one assertion level
higher so that it is not triggered by the (arbitrarily chosen level of) the
automatic tests.
(This is safer than ad-hoc quickly changing complicated but stable code.)
This is a "be nice" assertion (that was never intended for automated tests),
not a must have.

This resolves gap-system#3464
fingolfin pushed a commit that referenced this issue Jun 4, 2019
@hulpke @fingolfin
Make test more robust. (Address #3464)
97711e4 
Test for running, n ot concrete output. Also change one assertion level
higher so that it is not triggered by the (arbitrarily chosen level of) the
automatic tests.
(This is safer than ad-hoc quickly changing complicated but stable code.)
This is a "be nice" assertion (that was never intended for automated tests),
not a must have.

This resolves #3464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging a pull request may close this issue.

Performance improvements hulpke/gap
2 participants
@olexandr-konovalov @hulpke