-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements #3451
Performance improvements #3451
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3451 +/- ##
==========================================
+ Coverage 85.34% 85.38% +0.04%
==========================================
Files 699 699
Lines 346504 346767 +263
==========================================
+ Hits 295733 296099 +366
+ Misses 50771 50668 -103
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor remarks
04fda8b
to
52df9bc
Compare
Also RepresentativeAction for OnTuplesSets of points.
- ContainedConjugates uses perm. group orbits - Double cosets considers subgroups by increasing index - Move (same) calculation outside inner loop Fix assumption about generators of fphom Code wrongly assumed that isomorphism fo fp was always to free generators. This is not guaranteed (but so far always held, so was not spotted).
Use representation theory to predict which subgroup, w/o initial rewriting. Directly write down permrep for semidirect product. Moved twocohom.tst to teststandard, as it seems to be better place to reduce load on travis Added utility function to iterate through subgroups. Increasing index, initially don't attempt to compute whole lattice. Not in manual as it could make conjugates, ordering not perfect
Avoid infinite loop in bad cases of NHBNS. Allow slightly more generators in initial check.
Test for running, n ot concrete output. Also change one assertion level higher so that it is not triggered by the (arbitrarily chosen level of) the automatic tests. (This is safer than ad-hoc quickly changing complicated but stable code.) This is a "be nice" assertion (that was never intended for automated tests), not a must have. This resolves gap-system#3464
REMINDER - to all PR authors and reviewers: if a PR adds tests to |
Description
Improvements that mostly relate to computing double cosets, in particular in symmetric groups, and to permutation representations of extensions:
testextra/grpperm.tst
in master branch #3464Text for release notes
Performance of double coset calculations, in particular in symmetric and alternating groups, has been improved.