Simplify caching logic in GeneralMappingsFamily #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the cache consisted of a weak list with entries alternating between "keys" (= range domain) and "values" (= the corresponding mapping family). But the "values" contain the keys (via FamilyRange(fam). By exploiting that, we can simplify the caching logic. The resulting code is very similar to the code in DirectProductElementsFamily, suggesting that we can eventually replace both with a common abstraction.
fingolfin
added
the
release notes: not needed
Codecov Report
@@ Coverage Diff @@
## master #1888 +/- ##
===========================================
+ Coverage 50.92% 63.67% +12.75%
===========================================
Files 438 946 +508
Lines 232003 284493 +52490
Branches 10442 12746 +2304
===========================================
+ Hits 118138 181164 +63026
+ Misses 111082 100528 -10554
- Partials 2783 2801 +18
|
stevelinton
approved these changes
Nov 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the cache consisted of a weak list with entries alternating
between "keys" (= range domain) and "values" (= the corresponding mapping
family).
But the "values" contain the keys (via FamilyRange(fam). By exploiting that,
we can simplify the caching logic. The resulting code is very similar to the
code in DirectProductElementsFamily, suggesting that we can eventually replace
both with a common abstraction.