Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify caching logic in GeneralMappingsFamily #1888

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Simplify caching logic in GeneralMappingsFamily #1888

merged 1 commit into from
Nov 13, 2017

Commits on Nov 10, 2017

  1. Simplify caching logic in GeneralMappingsFamily 

    Previously, the cache consisted of a weak list with entries alternating
between "keys" (= range domain) and "values" (= the corresponding mapping
family).

But the "values" contain the keys (via FamilyRange(fam). By exploiting that,
we can simplify the caching logic. The resulting code is very similar to the
code in DirectProductElementsFamily, suggesting that we can eventually replace
both with a common abstraction.
    @fingolfin
    fingolfin committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    5344f02 View commit details
    Browse the repository at this point in the history