Add SUM_FLAGS to rank of IsomorphismPermGroup for IsPermGroup #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always want to return the IdentityMapping on a group when we call IsomorphismPermGroup
This was referenced Sep 17, 2018
fingolfin
approved these changes
Sep 17, 2018
|
Thanks @fingolfin – at least according to our tests, the |
wilfwilson
added
the
release notes: not needed
fingolfin
added
the
gapdays2018-fall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR arose from #2818).
As discussed by @fingolfin in #2818 (comment), different GAP library methods for
IsomorphismPermGroupfor a perm group apply, depending on which/how many packages are loaded. It seems sensible thatIsomorphismPermGroupshould always return theIdentityMappingfor a perm group. AddingSUM_FLAGSshould achieve this.Note that when/if this PR is merged, the tests in the development version of Semigroups will be able to run without errors in both the
masterandstable-4.10branches, given semigroups/Semigroups#524.