Accommodate changes in GAP affecting method ranks #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
force-pushed
the
method-reordering-fallout
branch
from
f021d29
to
b8e6c2d
Compare
|
gap-system/gap#2819 is merged and so this is ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in GAP
masterbranch mean that the ranks of certain filters have changed (see gap-system/gap#2818), which means that some rank adjustments related to the Semigroups package are not correct. To ensure compatibility with all versions of GAP I've made some changes.If I have done everything correctly, then the only failure in Travis will be GAP's
tst/testinstall/triviso.tst; this should be fixed if gap-system/gap#2819 is merged into GAP's master branch.This will therefore basically resolve #522.