-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert some Semigroups-related downrankings of Matrix methods #3674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I did not verify how this affects Semigroups or anything else, though -- i.e., I am trusting @wilfwilson on this (and am happy to do so).
I guess this could/should be backported to stable-4.11, right?
There is an additional FIXME that I didn't consider - I'll check it out shortly. |
Four downrankings were added in advance of GAP 4.10, to make sure that GAP did not break the Semigroups package, but only one of them was actually required. This commit reverts the other three.
b9bb07a
to
47d259f
Compare
I've also reverted the @fingolfin As for backporting, I don't mind. These downrankings didn't seem to be having any consequences, so I don't know whether backporting would make any noticeable difference to anything. Please add the backport tag if you think it's appropriate. |
Just to clarify, I ran the GAP |
Three downrankings of
Matrix
methods were added in advance of GAP 4.10, along with one forBaseDomain
, in order to make sure that GAP 4.10 did not break the Semigroups package. This was supposed to be temporary, and #2758 exists to revert this change.In fact, only one of these downrankings is required to keep Semigroups happy. This commit reverts the others. Once it is merged, I will update #2758 accordingly.
At some point (separately from this PR) I will try to see about removing the remaining downranking of a
Matrix
method.