Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the code setting up a subgroup data structure by the solvable radical method, which could lead to unexpected errors #3865

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Fix the code setting up a subgroup data structure by the solvable radical method, which could lead to unexpected errors #3865

merged 1 commit into from
Jan 22, 2020

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Jan 22, 2020

If we simply copy the pcisom, some routines that use the source get the
wrong group. This causes problem is using such algorithms on subgroups
obtained the same way.

This fixes #3864

Text for release notes

A bug in setting up a subgroup data structure by the solvable radical method has been fixed.

@hulpke hulpke added kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes backport-to-4.11 labels Jan 22, 2020
@hulpke
FIX: Induced fitting free setup requires own pcisom
a9e7041 
If we simply copy the pcisom, some routines that use the source get the
wrong group. This causes problem is using such algorithms on subgroups
obtained the same way.

This fixes gap-system#3864
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 84.82% when pulling a9e7041 on hulpke:fixes into 92c951d on gap-system:master.

fingolfin
fingolfin approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Jan 22, 2020
@fingolfin fingolfin merged commit b2dced0 into gap-system:master Jan 22, 2020
@fingolfin
Copy link
Member

Backported in commit e41efcd

@fingolfin fingolfin changed the title FIX: Induced fitting free setup requires own pcisom Fix the code setting up a subgroup data structure by the solvable radical method, which could lead to unexpected errors Jan 27, 2020
@fingolfin fingolfin added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jan 27, 2020
@hulpke hulpke mentioned this pull request Jan 28, 2020
Merged
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
@olexandr-konovalov olexandr-konovalov mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
backport-to-4.11-DONE kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

error in ConjugacyClasses computation
4 participants
@hulpke @coveralls @fingolfin @olexandr-konovalov