Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in ConjugacyClasses computation #3864

Closed
ThomasBreuer opened this issue Jan 22, 2020 · 2 comments · Fixed by #3865
Closed

error in ConjugacyClasses computation #3864

ThomasBreuer opened this issue Jan 22, 2020 · 2 comments · Fixed by #3865
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them

Comments

@ThomasBreuer
Copy link
Contributor

Gabriel Navarro has reported the following problem.
It happens in GAP 4.10.2 as well as in the current master branch.

gap> g:= Group( (1,2,3)(7,8)(12,13), (1,3)(2,4,5)(6,7,9,12,11,8,10,13), 
>               (1,4,3)(6,7)(8,11)(9,13)(10,12) );;
gap> max:= MaximalSubgroupClassReps( g );;
gap> ConjugacyClasses( max[1] );
Error, should not happen nonslv stabstack at /.../gapmaster/gap/lib/fitfree.gi:662 called from
OrbitsRepsAndStabsVectorsMultistage( o.stabradgens, 
 List( o.stabradgens, function ( x )
        return bas * npcgsact( x ) * basinv;
    end ), pcisom, o.stabrsubsz, solvtriv, o.stabfacgens, 
 List( o.stabfacgens, function ( x )
        return bas * npcgsact( x ) * basinv;
    end ), o.stabfacimgs, hom, o.subsz, OnRight, el 
 ) at /.../gapmaster/gap/lib/clashom.gi:2148 called from
LiftClassesEATrivRep( G, mpcgs, i, fants, hom, pcisom, solvtriv 
 ) at /.../gapmaster/gap/lib/clashom.gi:2478 called from
ConjugacyClassesViaRadical( G 
 ) at /.../gapmaster/gap/lib/clashom.gi:3087 called from
<function "ConjugacyClasses perm group">( <arguments> )
 called from read-eval loop at *stdin*:4
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
@ThomasBreuer ThomasBreuer added kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them backport-to-4.11 labels Jan 22, 2020
@fingolfin
Copy link
Member

That error message was inserted in a code change by @hulpke on 2013-02-22.

The error also happens in GAP 4.8 and 4.9. It works in GAP 4.6; in GAP 4.7, there is a different error:

gap> g:= Group( (1,2,3)(7,8)(12,13), (1,3)(2,4,5)(6,7,9,12,11,8,10,13),
>               (1,4,3)(6,7)(8,11)(9,13)(10,12) );;
gap> max:= MaximalSubgroupClassReps( g );;
gap> ConjugacyClasses( max[1] );
Error, matrix <mat> must be invertible called from
ProjectiveOrder( mat ) called from
Order( imgs[x] ) called from
func( elm ) called from
Filtered( [ 1 .. Length( imgs ) ], function ( x )
      return Order( imgs[x] ) > 1;
  end ) called from
LiftClassesEATrivRep( G, mpcgs, i, fants, hom, pcisom, solvtriv ) called from
...  at line 4 of *stdin*
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
brk>

@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Jan 22, 2020
hulpke added a commit to hulpke/gap that referenced this issue Jan 22, 2020
If we simply copy the pcisom, some routines that use the source get the
wrong group. This causes problem is using such algorithms on subgroups
obtained the same way.

This fixes gap-system#3864
hulpke added a commit to hulpke/gap that referenced this issue Jan 22, 2020
If we simply copy the pcisom, some routines that use the source get the
wrong group. This causes problem is using such algorithms on subgroups
obtained the same way.

This fixes gap-system#3864
hulpke added a commit to hulpke/gap that referenced this issue Jan 22, 2020
If we simply copy the pcisom, some routines that use the source get the
wrong group. This causes problem is using such algorithms on subgroups
obtained the same way.

This fixes gap-system#3864
hulpke added a commit to hulpke/gap that referenced this issue Jan 22, 2020
If we simply copy the pcisom, some routines that use the source get the
wrong group. This causes problem is using such algorithms on subgroups
obtained the same way.

This fixes gap-system#3864
@hulpke
Copy link
Contributor

hulpke commented Jan 22, 2020

The problem is that the fitting free data structure for the subgroup cannot just re-use the pc isomorphism for the radical of the whole group. Fixed.

fingolfin pushed a commit that referenced this issue Jan 22, 2020
If we simply copy the pcisom, some routines that use the source get the
wrong group. This causes problem is using such algorithms on subgroups
obtained the same way.

This fixes #3864
fingolfin pushed a commit that referenced this issue Jan 27, 2020
If we simply copy the pcisom, some routines that use the source get the
wrong group. This causes problem is using such algorithms on subgroups
obtained the same way.

This fixes #3864
hulpke added a commit to hulpke/gap that referenced this issue Jan 28, 2020
As previous fix did not work for matrix groups
hulpke added a commit to hulpke/gap that referenced this issue Jan 28, 2020
As previous fix did not work for matrix groups
hulpke added a commit to hulpke/gap that referenced this issue Jan 28, 2020
As previous fix did not work for matrix groups
hulpke added a commit to hulpke/gap that referenced this issue Jan 28, 2020
As previous fix did not work for matrix groups
hulpke added a commit to hulpke/gap that referenced this issue Jan 28, 2020
As previous fix did not work for matrix groups
hulpke added a commit that referenced this issue Jan 29, 2020
* FIX: Redid fix for #3864

As previous fix did not work for matrix groups

* FIX: Permutation rep. for automorphism group of fitting free

Ensure, if needed, that the permutation degree is reduced as far as we can
(to avoid that a stabilizer has multiple fixed points).

This resolves #3868

* FIX: Allow `SimpleGroup( "O+", 8, 2)` which had been broken

Fixed tab/blanks issue
hulpke added a commit to hulpke/gap that referenced this issue Jan 29, 2020
As previous fix did not work for matrix groups
fingolfin pushed a commit that referenced this issue Jan 29, 2020
* FIX: Redid fix for #3864

As previous fix did not work for matrix groups

* FIX: Permutation rep. for automorphism group of fitting free

Ensure, if needed, that the permutation degree is reduced as far as we can
(to avoid that a stabilizer has multiple fixed points).

This resolves #3868

* FIX: Allow `SimpleGroup( "O+", 8, 2)` which had been broken

Fixed tab/blanks issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
3 participants