Skip to content

Commit

Permalink
FIX: Redid fix for gap-system#3864
Browse files Browse the repository at this point in the history
As previous fix did not work for matrix groups
  • Loading branch information
hulpke committed Jan 28, 2020
1 parent 65ba5b3 commit 1fb5312
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions lib/fitfree.gi
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,16 @@ local ffs,hom,U,rest,ker,r,p,l,i,depths,pcisom;

# FittingFreeLiftSetup for U, if correct
if Size(RadicalGroup(Image(rest,U)))=1 then
pcisom:=List(ipcgs,x->ImagesRepresentative(ffs.pcisom,x));
pcisom:=GroupHomomorphismByImagesNC(U,SubgroupNC(Range(ffs.pcisom),pcisom),
ipcgs,pcisom);
if ipcgs=MappingGeneratorsImages(ffs.pcisom)[1] then
pcisom:=ffs.pcisom;
else
pcisom:=List(ipcgs,x->ImagesRepresentative(ffs.pcisom,x));
RUN_IN_GGMBI:=true;
pcisom:=GroupHomomorphismByImagesNC(Group(ipcgs),
SubgroupNC(Range(ffs.pcisom),pcisom),
ipcgs,pcisom);
RUN_IN_GGMBI:=false;
fi;
r:=rec(inducedfrom:=ffs,
pcgs:=ipcgs,
depths:=depths,
Expand Down

0 comments on commit 1fb5312

Please sign in to comment.