fix(dev): fix unresolved templates in cmd results #6850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
previously approved these changes
Feb 13, 2025
|
There are some test failures here. I'll take a look. |
thsig
force-pushed
the
dev-command-fixes
branch
5 times, most recently
from
8109854 to
986db2e
Compare
We were including the raw graph results in the results of commands requested over HTTP from the live page. This was always unnecessary (and the data structures involved were excessively large), but only started resulting in errors with our recent templating improvements (previously, we'd just leave the unresolved template strings in there). We can clean this up further in 0.14 when we get rid of `graphResults` from `ProcessCommandResult` (which will require fixing a bunch of test cases which currently use that field).
thsig
force-pushed
the
dev-command-fixes
branch
from
986db2e to
f170f83
Compare
eysi09
approved these changes
Feb 17, 2025
thsig
added a commit
that referenced
this pull request
Feb 20, 2025
This should fix a regression introduced in #6850.
thsig
added a commit
that referenced
this pull request
Feb 20, 2025
This should fix a regression introduced in #6850. Because we added a lookup into `graphResult.result` and `graphResult.result` can be null in certain circumstances (e.g. when the action fails), we needed to guard against this (since we don't want an internal error for such cases).
thsig
added a commit
that referenced
this pull request
Feb 20, 2025
This should fix a regression introduced in #6850. Because we added a lookup into `graphResult.result` and `graphResult.result` can be null in certain circumstances (e.g. when the action fails), we needed to guard against this (since we don't want an internal error for such cases).
thsig
added a commit
that referenced
this pull request
Feb 20, 2025
This should fix a regression introduced in #6850. Because we added a lookup into `graphResult.result` and `graphResult.result` can be null in certain circumstances (e.g. when the action fails), we needed to guard against this (since we don't want an internal error for such cases).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
This should fix a regression introduced in #6850. Because we added a lookup into `graphResult.result` and `graphResult.result` can be null in certain circumstances (e.g. when the action fails), we needed to guard against this (since we don't want an internal error for such cases).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We were including the raw graph results in the results of commands requested over HTTP from the live page. This was always unnecessary (and the data structures involved were excessively large), but only started resulting in errors with our recent templating improvements (previously, we'd just leave the unresolved template strings in there).
Which issue(s) this PR fixes:
Fixes live-mode commands run from the Cloud UI to fail under certain conditions.