Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): fix ink-divider warning message #6851

Closed
wants to merge 1 commit into from
Closed

Conversation

eysi09
Copy link
Collaborator

@eysi09 eysi09 commented Feb 13, 2025

What this PR does / why we need it:

We were using deprecated syntax for the Ink Divider component, causing a warning message about default props being deprecated. This fixes that.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

We were using deprecated syntax for the Ink Divider component, causing
a warning message about default props being deprecated. This fixes that.
@eysi09 eysi09 requested review from thsig and vvagaytsev February 13, 2025 16:35
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But there are some lint errors.

@thsig
Copy link
Collaborator

thsig commented Feb 13, 2025

@eysi09 Wasn't this fixed in my PR from today (with the other fixes for the dev command)?

@eysi09
Copy link
Collaborator Author

eysi09 commented Feb 13, 2025

@eysi09 Wasn't this fixed in my PR from today (with the other fixes for the dev command)?

Ah my bad. Closing.

@eysi09 eysi09 closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants