Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch GCR to Artifact-Registry #1067

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Switch GCR to Artifact-Registry #1067

merged 3 commits into from
Dec 19, 2023

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Dec 19, 2023

/kind technical-debt

Special notes for your reviewer

As discussed with @oliver-goetz :

switch to releases registry (policy: keep all images "forever"):

  • image: eu.gcr.io/gardener-project/ci-infra/*
  • --registry=eu.gcr.io/gardener-project/ci-infra
  • krte

Switch other occurrences to snapshots registry (policy: automatically purge any image after 30d).

@gardener-prow gardener-prow bot added the kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly label Dec 19, 2023
@ccwienk ccwienk requested a review from oliver-goetz December 19, 2023 17:58
@gardener-prow gardener-prow bot requested review from ary1992 and ScheererJ December 19, 2023 17:58
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2023
This was referenced Dec 19, 2023
Merged
Merged
Merged
Merged
oliver-goetz
oliver-goetz requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄
Found a couple of places where releases should be replaced by snapshots or vice versa. Otherwise, lgtm.

@ccwienk
Copy link
Member Author

ccwienk commented Dec 19, 2023

@oliver-goetz : thanks for reviewing - I squashed your suggestions

oliver-goetz
oliver-goetz approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Dec 19, 2023

LGTM label has been added.

Git tree hash: d01922127e1cbf62be7253d182add29e5995232c

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2023
@gardener-prow gardener-prow bot merged commit aacac62 into master Dec 19, 2023
1 check passed
@gardener-prow gardener-prow bot deleted the gcr-to-ar branch December 19, 2023 18:54
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Dec 19, 2023

@ccwienk: Updated the job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key dependency-watchdog-build-dev-images.yaml using file config/jobs/dependency-watchdog/dependency-watchdog-build-dev-images.yaml
  • key dependency-watchdog-check-vulnerabilities.yaml using file config/jobs/dependency-watchdog/dependency-watchdog-check-vulnerabilities.yaml
  • key dependency-watchdog-test-builds.yaml using file config/jobs/dependency-watchdog/dependency-watchdog-test-builds.yaml
  • key dependency-watchdog-unit-tests.yaml using file config/jobs/dependency-watchdog/dependency-watchdog-unit-tests.yaml
  • key extension-shoot-oidc-service-unit-tests.yaml using file config/jobs/extension-shoot-oidc-service/extension-shoot-oidc-service-unit-tests.yaml
  • key gardener-extension-networking-calico-unit-tests.yaml using file config/jobs/gardener-extension-networking-calico/gardener-extension-networking-calico-unit-tests.yaml
  • key gardener-extension-networking-cilium-unit-tests.yaml using file config/jobs/gardener-extension-networking-cilium/gardener-extension-networking-cilium-unit-tests.yaml
  • key gardener-extension-registry-cache-build-images.yaml using file config/jobs/gardener-extension-registry-cache/gardener-extension-registry-cache-build-images.yaml
  • key gardener-extension-registry-cache-e2e-kind.yaml using file config/jobs/gardener-extension-registry-cache/gardener-extension-registry-cache-e2e-kind.yaml
  • key gardener-extension-registry-cache-test-builds.yaml using file config/jobs/gardener-extension-registry-cache/gardener-extension-registry-cache-test-builds.yaml
  • key gardener-extension-registry-cache-unit-tests.yaml using file config/jobs/gardener-extension-registry-cache/gardener-extension-registry-cache-unit-tests.yaml
  • key gardener-extension-shoot-networking-filter-unit-tests.yaml using file config/jobs/gardener-extension-shoot-networking-filter/gardener-extension-shoot-networking-filter-unit-tests.yaml
  • key gardener-extension-shoot-rsyslog-relp-build-images.yaml using file config/jobs/gardener-extension-shoot-rsyslog-relp/gardener-extension-shoot-rsyslog-relp-build-images.yaml
  • key gardener-extension-shoot-rsyslog-relp-integration-tests.yaml using file config/jobs/gardener-extension-shoot-rsyslog-relp/gardener-extension-shoot-rsyslog-relp-integration-tests.yaml
  • key gardener-extension-shoot-rsyslog-relp-unit-tests.yaml using file config/jobs/gardener-extension-shoot-rsyslog-relp/gardener-extension-shoot-rsyslog-relp-unit-tests.yaml
  • key gardener-apidiff.yaml using file config/jobs/gardener/gardener-apidiff.yaml
  • key gardener-branch-cleaner.yaml using file config/jobs/gardener/gardener-branch-cleaner.yaml
  • key gardener-build-dev-images.yaml using file config/jobs/gardener/gardener-build-dev-images.yaml
  • key gardener-e2e-kind-ha-multi-zone-upgrade.yaml using file config/jobs/gardener/gardener-e2e-kind-ha-multi-zone-upgrade.yaml
  • key gardener-e2e-kind-ha-multi-zone.yaml using file config/jobs/gardener/gardener-e2e-kind-ha-multi-zone.yaml
  • key gardener-e2e-kind-ha-single-zone-upgrade.yaml using file config/jobs/gardener/gardener-e2e-kind-ha-single-zone-upgrade.yaml
  • key gardener-e2e-kind-ha-single-zone.yaml using file config/jobs/gardener/gardener-e2e-kind-ha-single-zone.yaml
  • key gardener-e2e-kind-migration-ha-single-zone.yaml using file config/jobs/gardener/gardener-e2e-kind-migration-ha-single-zone.yaml
  • key gardener-e2e-kind-migration.yaml using file config/jobs/gardener/gardener-e2e-kind-migration.yaml
  • key gardener-e2e-kind-operator.yaml using file config/jobs/gardener/gardener-e2e-kind-operator.yaml
  • key gardener-e2e-kind-upgrade.yaml using file config/jobs/gardener/gardener-e2e-kind-upgrade.yaml
  • key gardener-e2e-kind.yaml using file config/jobs/gardener/gardener-e2e-kind.yaml
  • key gardener-integration-tests.yaml using file config/jobs/gardener/gardener-integration-tests.yaml
  • key gardener-release-handler.yaml using file config/jobs/gardener/gardener-release-handler.yaml
  • key gardener-unit-tests.yaml using file config/jobs/gardener/gardener-unit-tests.yaml
  • key gardener-gardener-release-v1-84.yaml using file config/jobs/gardener/releases/gardener-gardener-release-v1-84.yaml
  • key gardener-gardener-release-v1-85.yaml using file config/jobs/gardener/releases/gardener-gardener-release-v1-85.yaml
  • key gardener-gardener-release-v1-86.yaml using file config/jobs/gardener/releases/gardener-gardener-release-v1-86.yaml

In response to this:

/kind technical-debt

Special notes for your reviewer

As discussed with @oliver-goetz :

switch to releases registry (policy: keep all images "forever"):

  • image: eu.gcr.io/gardener-project/ci-infra/*
  • --registry=eu.gcr.io/gardener-project/ci-infra
  • krte

Switch other occurrences to snapshots registry (policy: automatically purge any image after 30d).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-goetz oliver-goetz oliver-goetz approved these changes

@ary1992 ary1992 Awaiting requested review from ary1992

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

Assignees

@oliver-goetz oliver-goetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccwienk @oliver-goetz