Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch GCR -> Artifact-Registry #735

Merged
merged 3 commits into from
Dec 20, 2023
Merged

switch GCR -> Artifact-Registry #735

merged 3 commits into from
Dec 20, 2023

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Dec 12, 2023

GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

  • europe-docker.pkg.dev/gardener-project/snapshots for snapshots
  • europe-docker.pkg.dev/gardener-project/releases for releases
  • europe-docker.pkg.dev/gardener-project/public for combined view of snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

@ccwienk ccwienk requested a review from a team as a code owner December 12, 2023 13:25
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 12, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 12, 2023
shreyas-s-rao
shreyas-s-rao reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccwienk Thanks for the PR. Main question here is whether the older etcdbrctl, etcd-wrapper, and etcd-custom-image images have been copied over from GCR to artifact registry.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
shreyas-s-rao
shreyas-s-rao reviewed Dec 15, 2023
View reviewed changes
charts/images.yaml Outdated Show resolved Hide resolved
@shreyas-s-rao shreyas-s-rao added this to the v0.22.0 milestone Dec 15, 2023
@shreyas-s-rao
Copy link
Contributor

@ccwienk please also rebase the PR on latest master. Just a small change in Makefile (deploy target)

@ccwienk
Copy link
Member Author

ccwienk commented Dec 18, 2023

@christian Cwienk Thanks for the PR. Main question here is whether the older etcdbrctl, etcd-wrapper, and etcd-custom-image images have been copied over from GCR to artifact registry.

I copied currently referenced images as a one-off manual operation

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 18, 2023
@shreyas-s-rao
Copy link
Contributor

/retest

@ccwienk
switch GCR -> Artifact-Registry
2bc8075 
GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

- europe-docker.pkg.dev/gardener-project/snapshots for snapshots
- europe-docker.pkg.dev/gardener-project/releases for releases
- europe-docker.pkg.dev/gardener-project/public for read-access to
  snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 19, 2023
@ccwienk
Copy link
Member Author

ccwienk commented Dec 19, 2023

related pull-requests:

@shreyas-s-rao
Copy link
Contributor

/retest

shreyas-s-rao
shreyas-s-rao approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccwienk thanks for making the requested changes.
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 20, 2023
@shreyas-s-rao shreyas-s-rao merged commit fc174cd into master Dec 20, 2023
1 check passed
@shreyas-s-rao shreyas-s-rao deleted the gcr-to-ar branch December 20, 2023 12:01
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 20, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 20, 2023
shreyas-s-rao pushed a commit to shreyas-s-rao/etcd-druid that referenced this pull request Jan 11, 2024
@ccwienk @shreyas-s-rao
switch GCR -> Artifact-Registry (gardener#735)
c55c696
@shreyas-s-rao shreyas-s-rao mentioned this pull request Jan 11, 2024
Merged
ishan16696 added a commit that referenced this pull request Jan 11, 2024
@shreyas-s-rao @ccwienk @ishan16696
[hotfix-v0.21] Cherry-pick essential PRs and bug fixes (#756)
51e9b28 
* switch GCR -> Artifact-Registry (#735)

* Fix artifact registry issue to push dev images to europe-docker.pkg.dev/gardener-project/snapshots (#745)

* Update the etcd-backup-restore images with lastest releases (#752)

v0.24.7 -> v0.24.8

v0.27.0 -> v0.28.0

---------

Co-authored-by: Christian Cwienk <christian.cwienk@sap.com>
Co-authored-by: Ishan Tyagi <42602577+ishan16696@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ccwienk @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot