Skip to content

Commit

Permalink
[hotfix-v0.21] Cherry-pick essential PRs and bug fixes (#756)
Browse files Browse the repository at this point in the history
* switch GCR -> Artifact-Registry (#735)

* Fix artifact registry issue to push dev images to europe-docker.pkg.dev/gardener-project/snapshots (#745)

* Update the etcd-backup-restore images with lastest releases (#752)

v0.24.7 -> v0.24.8

v0.27.0 -> v0.28.0

---------

Co-authored-by: Christian Cwienk <christian.cwienk@sap.com>
Co-authored-by: Ishan Tyagi <42602577+ishan16696@users.noreply.github.com>
  • Loading branch information
3 people authored Jan 11, 2024
1 parent 83c84c7 commit 51e9b28
Show file tree
Hide file tree
Showing 12 changed files with 37 additions and 32 deletions.
19 changes: 12 additions & 7 deletions .ci/pipeline_definitions
Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
etcd-druid:
template: 'default'
base_definition:
repo: ~
traits:
version:
preprocess:
'inject-commit-hash'
inject_effective_version: true
component_descriptor:
ocm_repository: europe-docker.pkg.dev/gardener-project/snapshots
publish:
oci-builder: 'docker-buildx'
platforms:
- linux/amd64
- linux/arm64
dockerimages:
etcd-druid:
registry: 'gcr-readwrite'
image: 'eu.gcr.io/gardener-project/gardener/etcd-druid'
image: europe-docker.pkg.dev/gardener-project/snapshots/gardener/etcd-druid
dockerfile: 'Dockerfile'
inputs:
repos:
Expand Down Expand Up @@ -46,15 +45,22 @@ etcd-druid:
head-update:
traits:
draft_release: ~
component_descriptor: ~
component_descriptor:
ocm_repository_mappings:
- repository: europe-docker.pkg.dev/gardener-project/releases
pull-request:
traits:
pull-request: ~
component_descriptor: ~
release:
traits:
version:
preprocess: 'finalize'
component_descriptor:
ocm_repository: europe-docker.pkg.dev/gardener-project/releases
publish:
dockerimages:
etcd-druid:
image: europe-docker.pkg.dev/gardener-project/releases/gardener/etcd-druid
release:
nextversion: 'bump_minor'
git_tags:
Expand All @@ -66,4 +72,3 @@ etcd-druid:
internal_scp_workspace:
channel_name: 'C0177NLL8V9' # gardener-etcd
slack_cfg_name: 'scp_workspace'
component_descriptor: ~
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
# Image URL to use all building/pushing image targets
VERSION := $(shell cat VERSION)
REPO_ROOT := $(shell dirname "$(realpath $(lastword $(MAKEFILE_LIST)))")
REGISTRY := eu.gcr.io/gardener-project/gardener
IMAGE_REPOSITORY := $(REGISTRY)/etcd-druid
REGISTRY := europe-docker.pkg.dev/gardener-project/snapshots
IMAGE_REPOSITORY := $(REGISTRY)/gardener/etcd-druid
IMAGE_BUILD_TAG := $(VERSION)
BUILD_DIR := build
PROVIDERS := ""
Expand Down Expand Up @@ -155,7 +155,7 @@ update-dependencies:
.PHONY: add-license-headers
add-license-headers: $(GO_ADD_LICENSE)
@./hack/addlicenseheaders.sh ${YEAR}

.PHONY: kind-up
kind-up: $(KIND)
@printf "\n\033[0;33m📌 NOTE: To target the newly created KinD cluster, please run the following command:\n\n export KUBECONFIG=$(KUBECONFIG_PATH)\n\033[0m\n"
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
fullSnapshotSchedule: 0 */24 * * *
garbageCollectionPeriod: 43200s
garbageCollectionPolicy: Exponential
imageRepository: eu.gcr.io/gardener-project/gardener/etcdbrctl
imageRepository: europe-docker.pkg.dev/gardener-project/public/gardener/etcdbrctl
imageVersion: v0.25.0
port: 8080
resources:
Expand All @@ -67,7 +67,7 @@ spec:
clientPort: 2379
defragmentationSchedule: 0 */24 * * *
enableTLS: false
imageRepository: eu.gcr.io/gardener-project/gardener/etcd-wrapper
imageRepository: europe-docker.pkg.dev/gardener-project/public/gardener/etcd-wrapper
imageVersion: v0.1.0
initialClusterState: new
initialClusterToken: new
Expand Down
4 changes: 2 additions & 2 deletions api/v1alpha1/types_etcd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ func getEtcd(name, namespace string) *Etcd {
deltaSnapshotPeriod := metav1.Duration{
Duration: 300 * time.Second,
}
imageEtcd := "eu.gcr.io/gardener-project/gardener/etcd-wrapper:v0.1.0"
imageBR := "eu.gcr.io/gardener-project/gardener/etcdbrctl:v0.25.0"
imageEtcd := "europe-docker.pkg.dev/gardener-project/public/gardener/etcd-wrapper:v0.1.0"
imageBR := "europe-docker.pkg.dev/gardener-project/public/gardener/etcdbrctl:v0.25.0"
snapshotSchedule := "0 */24 * * *"
defragSchedule := "0 */24 * * *"
container := "my-object-storage-container-name"
Expand Down
2 changes: 1 addition & 1 deletion charts/druid/values.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
crds:
enabled: true
image:
repository: eu.gcr.io/gardener-project/gardener/etcd-druid
repository: europe-docker.pkg.dev/gardener-project/public/gardener/etcd-druid
tag: latest
imagePullPolicy: IfNotPresent
replicas: 1
Expand Down
14 changes: 7 additions & 7 deletions charts/images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,22 @@ images:
resourceId:
name: 'etcdbrctl'
sourceRepository: github.com/gardener/etcd-backup-restore
repository: eu.gcr.io/gardener-project/gardener/etcdbrctl
tag: "v0.24.7"
repository: europe-docker.pkg.dev/gardener-project/public/gardener/etcdbrctl
tag: "v0.24.8"
- name: etcd
sourceRepository: github.com/gardener/etcd-custom-image
repository: eu.gcr.io/gardener-project/gardener/etcd
repository: europe-docker.pkg.dev/gardener-project/public/gardener/etcd
tag: "v3.4.26-3"
- name: etcd-backup-restore-distroless
resourceId:
name: 'etcdbrctl'
sourceRepository: github.com/gardener/etcd-backup-restore
repository: eu.gcr.io/gardener-project/gardener/etcdbrctl
tag: "v0.27.0"
repository: europe-docker.pkg.dev/gardener-project/public/gardener/etcdbrctl
tag: "v0.28.0"
- name: etcd-wrapper
sourceRepository: github.com/gardener/etcd-wrapper
repository: eu.gcr.io/gardener-project/gardener/etcd-wrapper
repository: europe-docker.pkg.dev/gardener-project/public/gardener/etcd-wrapper
tag: "v0.1.0"
- name: alpine
repository: eu.gcr.io/gardener-project/3rd/alpine
repository: europe-docker.pkg.dev/gardener-project/public/3rd/alpine
tag: "3.18.4"
2 changes: 1 addition & 1 deletion config/default/manager_image_patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ spec:
spec:
containers:
# Change the value of image field below to your controller image URL
- image: eu.gcr.io/gardener-project/gardener/etcd-druid:v0.21.0
- image: europe-docker.pkg.dev/gardener-project/public/gardener/etcd-druid:v0.21.0
name: druid
6 changes: 3 additions & 3 deletions pkg/component/etcd/statefulset/statefulset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ var (
backupPort int32 = 8080
wrapperPort int32 = 9095
uid = "a9b8c7d6e5f4"
imageEtcd = "eu.gcr.io/gardener-project/gardener/etcd-wrapper:v0.1.0"
imageBR = "eu.gcr.io/gardener-project/gardener/etcdbrctl:v0.25.0"
imageInitContainer = "eu.gcr.io/gardener-project/3rd/alpine:3.18.4"
imageEtcd = "europe-docker.pkg.dev/gardener-project/releases/gardener/etcd-wrapper:v0.1.0"
imageBR = "europe-docker.pkg.dev/gardener-project/releases/gardener/etcdbrctl:v0.25.0"
imageInitContainer = "europe-docker.pkg.dev/gardener-project/releases/3rd/alpine:3.18.4"
snapshotSchedule = "0 */24 * * *"
defragSchedule = "0 */24 * * *"
container = "default.bkp"
Expand Down
4 changes: 2 additions & 2 deletions skaffold.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build:
local:
useBuildkit: true
artifacts:
- image: eu.gcr.io/gardener-project/gardener/etcd-druid
- image: europe-docker.pkg.dev/gardener-project/public/gardener/etcd-druid
docker:
dockerfile: Dockerfile
target: druid
Expand All @@ -18,7 +18,7 @@ deploy:
chartPath: charts/druid
namespace: default
artifactOverrides:
image: eu.gcr.io/gardener-project/gardener/etcd-druid
image: europe-docker.pkg.dev/gardener-project/public/gardener/etcd-druid
imageStrategy:
helm: {}
skipBuildDependencies: true
Expand Down
2 changes: 1 addition & 1 deletion test/integration/controllers/compaction/reconciler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ func createCompactionJob(instance *druidv1alpha1.Etcd) *batchv1.Job {
Containers: []corev1.Container{
{
Name: "compact-backup",
Image: "eu.gcr.io/gardener-project/3rd/alpine:3.18.4",
Image: "europe-docker.pkg.dev/gardener-project/releases/3rd/alpine:3.18.4",
Command: []string{"sh", "-c", "tail -f /dev/null"},
},
},
Expand Down
4 changes: 2 additions & 2 deletions test/utils/etcd.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ var (
clientPort int32 = 2379
serverPort int32 = 2380
backupPort int32 = 8080
imageEtcd = "eu.gcr.io/gardener-project/gardener/etcd-wrapper:v0.1.0"
imageBR = "eu.gcr.io/gardener-project/gardener/etcdbrctl:v0.25.0"
imageEtcd = "europe-docker.pkg.dev/gardener-project/public/gardener/etcd-wrapper:v0.1.0"
imageBR = "europe-docker.pkg.dev/gardener-project/public/gardener/etcdbrctl:v0.25.0"
snapshotSchedule = "0 */24 * * *"
defragSchedule = "0 */24 * * *"
container = "default.bkp"
Expand Down
2 changes: 1 addition & 1 deletion test/utils/etcdcopybackupstask.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func CreateEtcdCopyBackupsJob(taskName, namespace string) *batchv1.Job {
Containers: []corev1.Container{
{
Name: "copy-backups",
Image: "eu.gcr.io/gardener-project/gardener/etcdbrctl",
Image: "europe-docker.pkg.dev/gardener-project/public/gardener/etcdbrctl",
ImagePullPolicy: corev1.PullIfNotPresent,
Args: []string{"copy"}, // since this is only used for testing the command here is not complete.
},
Expand Down

0 comments on commit 51e9b28

Please sign in to comment.