Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-v0.21] Cherry-pick essential PRs and bug fixes #756

Merged
merged 3 commits into from
Jan 11, 2024
Merged

[hotfix-v0.21] Cherry-pick essential PRs and bug fixes #756

merged 3 commits into from
Jan 11, 2024

Conversation

shreyas-s-rao
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao commented Jan 11, 2024 •
edited
Loading

How to categorize this PR?

/area backup
/kind bug

What this PR does / why we need it:
Cherry-picks of PRs:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @ishan16696

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

A regression in chunk deletion behavior for openstack provider has now been fixed.

Add unit tests for chunk deletion

Add support for overriding storage API endpoint for provider GCS, by setting environment variable `GOOGLE_STORAGE_API_ENDPOINT`, with the value in the format `http[s]://host[:port]/storage/v1/`. ⚠️ Note: GCS storage API endpoint will not be overridden for `copy` subcommand, since backup buckets may reside in different regions.

Dynamic loading of IaaS credentials is now optimized to make use of file system information instead of calculating a hash of the credentials to detect changes.

@shreyas-s-rao shreyas-s-rao added this to the v0.22.0 milestone Jan 11, 2024
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner January 11, 2024 13:12
@gardener-robot gardener-robot added the needs/review Needs review label Jan 11, 2024
@gardener-robot gardener-robot added area/backup Backup related kind/bug Bug size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 11, 2024
@shreyas-s-rao
Copy link
Contributor Author

/hold

The prow job pull-etcd-druid-e2e-kind runs with default settings of druid, and pull-etcd-druid-e2e-kind-nondistroless-etcd runs druid with UseEtcdWrapper feature gate set to false. Since the feature gate is still set to alpha state in this branch hotfix-v0.21, etcd-wrapper is never tested in this PR.

I will run the e2e test locally and post the result here, after which we can merge the PR.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jan 11, 2024
@ishan16696
Copy link
Member

e2e-tests.log
druid e2e tests with UseEtcdWrapper =true passed

@ishan16696 ishan16696 removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jan 11, 2024
@ishan16696 ishan16696 merged commit 51e9b28 into gardener:hotfix-v0.21 Jan 11, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 11, 2024
@shreyas-s-rao shreyas-s-rao deleted the cherry-picks-hotfix-v0.21 branch January 11, 2024 17:17
@shreyas-s-rao shreyas-s-rao self-assigned this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 Awaiting requested review from ishan16696

Assignees

@shreyas-s-rao shreyas-s-rao

Labels
area/backup Backup related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@shreyas-s-rao @ishan16696 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot @ccwienk