Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local cloud provider #1434

Merged
merged 17 commits into from
Mar 15, 2023
Merged

Support local cloud provider #1434

merged 17 commits into from
Mar 15, 2023

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Mar 1, 2023

What this PR does / why we need it:
This PR has several improvements regarding unsupported cloud providers.

If no (valid) cloud provider is configured that the dashboard supports, this will no longer result in an fatal error 500. Instead this will be rendered as an information in the dashboard
Screenshot 2023-02-28 at 14 47 42
Screenshot 2023-02-28 at 14 48 04

Added a generic secret dialog as well as fallback implementation for all required code parts. Start implementing support for a new cloud provider is now as simple as adding the name of the new provider to the list of supported providers. This will be further enhanced with follow-up PR #1436

Added support for Gardener local infrastructure provider
Screenshot 2023-03-01 at 10 48 36
Screenshot 2023-03-01 at 10 54 44

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

If no (valid) cloud provider is configured that the dashboard supports, this will no longer result in an fatal error 500. Instead this will be rendered as an alert in the dashboard
Added support for `local` infrastructure provider. This allows to use the dashboard with local gardener installations. See also: [Deploying Gardener locally](https://github.com/gardener/gardener/blob/master/docs/deployment/getting_started_locally.md)
Fixed: The Dashboard did not recognize `providerTypes: ['*']` as valid `seedSelector`
Fixed: Seeds in other regions than the shoot did not show up if no `seedCandidateDeterminationStrategy` set in dashboard config

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2023
Use key insensitive whitelist keys for secret data
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 1, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2023
…eedCandidateDeterminationStrategy` set in dashboard config
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@gardener-robot
Copy link

@holgerkoser You have pull request review open invite, please check

backend/lib/services/cloudProviderSecrets.js Outdated Show resolved Hide resolved
docs/development/local-setup.md Outdated Show resolved Hide resolved
frontend/src/components/dialogs/SecretDialogGeneric.vue Outdated Show resolved Hide resolved
frontend/src/components/dialogs/SecretDialogGeneric.vue Outdated Show resolved Hide resolved
frontend/src/components/dialogs/SecretDialogGeneric.vue Outdated Show resolved Hide resolved
frontend/src/mixins/shootItem.js Show resolved Hide resolved
frontend/src/views/NewShoot.vue Outdated Show resolved Hide resolved
frontend/src/views/NewShoot.vue Outdated Show resolved Hide resolved
frontend/src/views/Secrets.vue Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 14, 2023
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 14, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 14, 2023
@petersutter petersutter self-requested a review March 14, 2023 16:04
@grolu grolu changed the title Support generic cloud providers Support local cloud providers Mar 15, 2023
@grolu grolu changed the title Support local cloud providers Support local cloud provider Mar 15, 2023
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Mar 15, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 15, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 15, 2023
@grolu grolu merged commit 155a068 into master Mar 15, 2023
@grolu grolu deleted the enh/generic_cloudprovider branch March 15, 2023 12:00
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 15, 2023
@grolu grolu mentioned this pull request Mar 21, 2023
7 tasks
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants