-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Add cloud providers via configuration #1436
Conversation
Use key insensitive whitelist keys for secret data
…eedCandidateDeterminationStrategy` set in dashboard config
return undefined | ||
|
||
try { | ||
return require(`@/assets/${this.value}.svg`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this. I think it will not work as expected because there is a webpack build step involved which creates hash values for the assets and returns a pathname with the hash value. In this case webpack cannot know the path and the require will not work at runtime??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are probably right. I did not think about the webpack build step. I need to adjust this anyway to support images mounted via configuration. I will revert the other changes
Edit: I checked this with a production build and it seems to work... although I'm actually not sure why. Maybe we should not do it anyway as I do not have a good feeling about this.
@grolu You need rebase this pull request with latest master branch. Please check. |
# Conflicts: # backend/lib/services/cloudProviderSecrets.js # backend/lib/services/cloudprofiles.js # docs/development/local-setup.md # frontend/src/components/dialogs/SecretDialogGeneric.vue # frontend/src/store/index.js # frontend/src/views/NewShoot.vue # frontend/src/views/Secrets.vue
Added possibility to configure required dependencies between multiple fields Added possibility to configure yaml and json textarea inputs Removed hard-coded fallback yaml input field. Now this is also generated
# Conflicts: # frontend/src/components/VendorIcon.vue # frontend/src/store/index.js
Implemented all required chart template changes and tests
# Conflicts: # charts/__tests__/gardener-dashboard/runtime/dashboard/__snapshots__/configmap.spec.js.snap # charts/__tests__/gardener-dashboard/runtime/dashboard/configmap.spec.js # charts/gardener-dashboard/charts/runtime/templates/dashboard/configmap.yaml # charts/gardener-dashboard/values.yaml
# Conflicts: # frontend/src/components/ShootWorkers/WorkerConfiguration.vue
Closed in favor of #1553 (adopted to vue3 branch) |
What this PR does / why we need it:
On top of PR #1434 this PR adds logic to define additional cloud providers via configuration (
customCloudProviders
).It is possible to define a custom secret dialog including validation and help texts.
A custom cloud provider icon can be defined using an image resource mounted via asset configuration
This PR also adds a configuration option for the available cloud providers (
cloudProviderList
). This allows to add additional cloud providers as well as their order in the Dashboard. It is possible to add cloud providers without additional configuration, the secret dialog and logo will fallback to generic input / icon.Current Limitations:
No additional input fields on create cluster page, see #1445
Example dashboard configuration for a cloud provider with name
custom
Icons can be provided as base64 encoded values when using the helm chart in the frontendConfig.vendorAssets map. Those icons can then be refrenced in the vendor configurations as well as the help html as shown above.
Cloud provider
custom
rendered in the DashboardWhich issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
Release note: