Skip to content

Commit

Permalink
Skip scale-up checks for first member of etcd cluster. (#649)
Browse files Browse the repository at this point in the history
* Skip scale-up checks for first member of etcd cluster.

* Add a TODO comment.
  • Loading branch information
ishan16696 authored Aug 2, 2023
1 parent 37e073e commit 4580150
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions pkg/initializer/initializer.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"fmt"
"os"
"path/filepath"
"strings"
"time"

"github.com/gardener/etcd-backup-restore/pkg/errors"
Expand Down Expand Up @@ -57,8 +58,15 @@ func (e *EtcdInitializer) Initialize(mode validator.Mode, failBelowRevision int6
ctx := context.Background()
var err error

//Etcd cluster scale-up case
if miscellaneous.IsMultiNode(logger) {
podName, err := miscellaneous.GetEnvVarOrError("POD_NAME")
if err != nil {
logger.Fatalf("Error reading POD_NAME env var : %v", err)
}

// Etcd cluster scale-up case
// Note: first member of etcd cluster can never be part of scale-up case.
// TODO: consider removing this special check for first cluster member when backup-restore can check presence of any member in cluster.
if miscellaneous.IsMultiNode(logger) && !strings.HasSuffix(podName, "0") {
clientSet, err := miscellaneous.GetKubernetesClientSetOrError()
if err != nil {
logger.Fatalf("failed to create clientset, %v", err)
Expand Down

0 comments on commit 4580150

Please sign in to comment.