Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip scale-up checks for first member of etcd cluster. #649

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Skip scale-up checks for first member of etcd cluster. #649

merged 2 commits into from
Aug 2, 2023

Conversation

ishan16696
Copy link
Member

@ishan16696 ishan16696 commented Jul 19, 2023 •
edited
Loading

What this PR does / why we need it:
This PR enables the first member to skips the scale-up checks as first member of etcd cluster can never be part of scale-up(1->3 replicas). please check this: #646 (comment)

Which issue(s) this PR fixes:
Fixes #646

Special notes for your reviewer:

Release note:

While scaling up a non-HA etcd cluster to HA skipping the scale-up checks for first member of etcd cluster as first member can never be a part of scale-up scenarios.

@ishan16696 ishan16696 requested a review from a team as a code owner July 19, 2023 05:30
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 19, 2023
@ishan16696 ishan16696 added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jul 19, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 19, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 19, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 19, 2023
@ishan16696 ishan16696 removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jul 19, 2023
@ishan16696 ishan16696 mentioned this pull request Jul 20, 2023
Merged
@ishan16696 ishan16696 removed their assignment Jul 27, 2023
@shreyas-s-rao shreyas-s-rao self-assigned this Jul 31, 2023
shreyas-s-rao
shreyas-s-rao reviewed Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishan16696 thanks for the quick fix. Can you please add a TODO comment to the fix as mentioned below? Thanks

pkg/initializer/initializer.go Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 1, 2023
@shreyas-s-rao shreyas-s-rao added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2023
shreyas-s-rao
shreyas-s-rao approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 2, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2023
@ishan16696 ishan16696 merged commit 4580150 into gardener:master Aug 2, 2023
1 check passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 2, 2023
shreyas-s-rao pushed a commit to shreyas-s-rao/etcd-backup-restore that referenced this pull request Aug 2, 2023
@ishan16696 @shreyas-s-rao
Skip scale-up checks for first member of etcd cluster. (gardener#649)
ef2096a
shreyas-s-rao pushed a commit to shreyas-s-rao/etcd-backup-restore that referenced this pull request Aug 2, 2023
@ishan16696 @shreyas-s-rao
Skip scale-up checks for first member of etcd cluster. (gardener#649)
f45fdab
This was referenced Aug 2, 2023
Merged
Merged
shreyas-s-rao added a commit that referenced this pull request Aug 2, 2023
@shreyas-s-rao @ishan16696
Skip scale-up checks for first member of etcd cluster. (#649) (#655)
7d97afa 
Co-authored-by: Ishan Tyagi <42602577+ishan16696@users.noreply.github.com>
shreyas-s-rao added a commit that referenced this pull request Aug 2, 2023
@shreyas-s-rao @ishan16696
Skip scale-up checks for first member of etcd cluster. (#649) (#654)
c8cb018 
Co-authored-by: Ishan Tyagi <42602577+ishan16696@users.noreply.github.com>
@ishan16696 ishan16696 deleted the optimise/scale-up branch August 7, 2023 05:37
@seshachalam-yv seshachalam-yv added this to the v0.26.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@aaronfern aaronfern aaronfern approved these changes

Assignees

@ishan16696 ishan16696

Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging this pull request may close these issues.

[BUG] Restart of first cluster member can lead to quorum loss while scaling up a non-HA etcd cluster.
7 participants
@ishan16696 @shreyas-s-rao @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot @seshachalam-yv