-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip scale-up checks for first member of etcd cluster. #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Needs review
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
labels
Jul 19, 2023
ishan16696
added
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Jul 19, 2023
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 19, 2023
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 19, 2023
ishan16696
force-pushed
the
optimise/scale-up
branch
from
July 19, 2023 07:21
645023e
to
aa763ba
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 19, 2023
ishan16696
removed
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishan16696 thanks for the quick fix. Can you please add a TODO
comment to the fix as mentioned below? Thanks
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 1, 2023
shreyas-s-rao
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 2, 2023
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 2, 2023
shreyas-s-rao
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
labels
Aug 2, 2023
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 2, 2023
aaronfern
reviewed
Aug 2, 2023
aaronfern
approved these changes
Aug 2, 2023
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Aug 2, 2023
shreyas-s-rao
pushed a commit
to shreyas-s-rao/etcd-backup-restore
that referenced
this pull request
Aug 2, 2023
shreyas-s-rao
pushed a commit
to shreyas-s-rao/etcd-backup-restore
that referenced
this pull request
Aug 2, 2023
This was referenced Aug 2, 2023
shreyas-s-rao
added a commit
that referenced
this pull request
Aug 2, 2023
shreyas-s-rao
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Bug
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enables the first member to skips the scale-up checks as first member of etcd cluster can never be part of scale-up(
1->3 replicas
). please check this: #646 (comment)Which issue(s) this PR fixes:
Fixes #646
Special notes for your reviewer:
Release note: