Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip scale-up checks for first member of etcd cluster. (#649) #655

Conversation

shreyas-s-rao
Copy link
Collaborator

What this PR does / why we need it:
Cherry-pick of #649.

This PR enables the first member to skips the scale-up checks as first member of etcd cluster can never be part of scale-up(1->3 replicas). please check this: #646 (comment).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

While scaling up a non-HA etcd cluster to HA skipping the scale-up checks for first member of etcd cluster as first member can never be a part of scale-up scenarios.

@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner August 2, 2023 07:19
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 2, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 2, 2023
@shreyas-s-rao shreyas-s-rao merged commit 7d97afa into gardener:hotfix-v0.25 Aug 2, 2023
1 check passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 2, 2023
@shreyas-s-rao shreyas-s-rao deleted the cherry/pr-649/hotfix-v0.25 branch August 2, 2023 09:54
@shreyas-s-rao shreyas-s-rao self-assigned this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants