Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Label-Selector, Pod Template label updates and TLS changes for client and peer communication #883

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fixes Label-Selector, Pod Template label updates and TLS changes for client and peer communication #883

merged 2 commits into from
Oct 23, 2024

Conversation

unmarshall
Copy link
Contributor

@unmarshall unmarshall commented Oct 1, 2024 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #881

Special notes for your reviewer:

Release note:

Fixed the ready condition for the Etcd resource.

Fixes for handling of pod template labels, label-selector, replicas and TLS changes to Etcd resource. StatefulSet does not allow update of label-selector. v0.23.x changes the label-selector, to get that reflected in the STS, it will be orphan deleted and subsequently created. Similarly for peer TLS and pod label changes an update of pods will be done. For single member etcd clusters this will cause a transient downtime. If replicas, TLS, label-selector are changed together then it will also cause transient quorum loss in multi-node etcd clusters.

etcd-backup-restore has been bumped to v0.30.2 and etcd-wrapper has been bumped to v0.2.0.

If you wish to downgrade from druid `v0.23.x` to versions =<`v0.22.7`, please ensure that you change the CLI flags for the druid command to remove the new CLI flags introduced in `v0.23.0`. If you are using the provided helm charts to deploy druid, you may ignore this and simply deploy the helm chart, which takes care of the CLI flag changes for you.

etcd-backup-restore now triggers a restart of the etcd member after updating etcd's advertise peer URLs if found updated.

Introduced a CLI flag `--use-etcd-wrapper` (default: false) to enable/disable the backup-restore to use etcd-wrapper related functionality. Note: enable this flag only if etcd-wrapper is deployed.

Added a capability to stop the etcd-wrapper container by exposing an endpoint `/stop`. 

Upgrade the Go dependency to `go1.23.1`.

ops/print-etcd-cert-paths.sh has been removed and is now replaced with ops/print-etcd-cheatsheet.sh

@unmarshall unmarshall requested a review from a team as a code owner October 1, 2024 03:49
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Oct 1, 2024
@unmarshall unmarshall mentioned this pull request Oct 1, 2024
Closed
@gardener-robot gardener-robot added the needs/second-opinion Needs second review by someone else label Oct 1, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 1, 2024
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-nondistroless-etcd

@ishan16696
Copy link
Member

@unmarshall can you also mention the test cases for which you have tested this PR.

@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-nondistroless-etcd

1 similar comment
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-nondistroless-etcd

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 1, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 1, 2024
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 2, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 8, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
@unmarshall
fixes gardener#881, gardener#877
1a14060 
Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23
Added use-etcd-wrapper cli arg for etcdbr container
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
shreyas-s-rao
shreyas-s-rao approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the requested changes!

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
ishan16696
ishan16696 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishan16696
Copy link
Member

ishan16696 commented Oct 23, 2024 •
edited
Loading

Before merging the PR @unmarshall please update the release notes as you have reverted the change of adding the cluster-size annotation.

@shreyas-s-rao
Copy link
Contributor

@ishan16696 done, thanks!

@shreyas-s-rao shreyas-s-rao merged commit 8b9fb87 into gardener:master Oct 23, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 23, 2024
shreyas-s-rao pushed a commit to shreyas-s-rao/etcd-druid that referenced this pull request Oct 23, 2024
@unmarshall @shreyas-s-rao
Fixes Label-Selector, Pod Template label updates and TLS changes for …
460f309 
…client and peer communication (gardener#883)

* fixes gardener#881, gardener#877
* Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23
* Added use-etcd-wrapper cli arg for etcdbr container
* removed etcd-cluster-size label to be added later with ability to restore while keep etcd.spec.replicas > 1
@shreyas-s-rao
Copy link
Contributor

/cherry-pick hotfix-v0.23

@gardener-robot gardener-robot added the needs/cherry-pick Needs to be cherry-picked to older version label Oct 23, 2024
This was referenced Oct 23, 2024
Open
Merged
@unmarshall unmarshall deleted the fixv0.23 branch October 23, 2024 14:02
shreyas-s-rao added a commit that referenced this pull request Oct 23, 2024
@shreyas-s-rao @unmarshall
Fixes Label-Selector, Pod Template label updates and TLS changes for …
fa13ba7 
…client and peer communication (#883) (#894)

* fixes #881, #877
* Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23
* Added use-etcd-wrapper cli arg for etcdbr container
* removed etcd-cluster-size label to be added later with ability to restore while keep etcd.spec.replicas > 1

Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

@shreyas-s-rao shreyas-s-rao Awaiting requested review from shreyas-s-rao

Assignees

@shreyas-s-rao shreyas-s-rao

@ishan16696 ishan16696

Labels
area/control-plane Control plane related kind/bug Bug needs/cherry-pick Needs to be cherry-picked to older version needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
7 participants
@unmarshall @ishan16696 @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot