Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-v0.23] Fixes Label-Selector, Pod Template label updates and TLS changes for client and peer communication (#883) #894

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[hotfix-v0.23] Fixes Label-Selector, Pod Template label updates and TLS changes for client and peer communication (#883) #894

merged 1 commit into from
Oct 23, 2024

Conversation

shreyas-s-rao
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
Cherry-pick of #883

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed the ready condition for the Etcd resource.

Fixes for handling of pod template labels, label-selector, replicas and TLS changes to Etcd resource. StatefulSet does not allow update of label-selector. v0.23.x changes the label-selector, to get that reflected in the STS, it will be orphan deleted and subsequently created. Similarly for peer TLS and pod label changes an update of pods will be done. For single member etcd clusters this will cause a transient downtime. If replicas, TLS, label-selector are changed together then it will also cause transient quorum loss in multi-node etcd clusters.

etcd-backup-restore has been bumped to v0.30.2 and etcd-wrapper has been bumped to v0.2.0.

If you wish to downgrade from druid `v0.23.x` to versions =<`v0.22.7`, please ensure that you change the CLI flags for the druid command to remove the new CLI flags introduced in `v0.23.0`. If you are using the provided helm charts to deploy druid, you may ignore this and simply deploy the helm chart, which takes care of the CLI flag changes for you.

etcd-backup-restore now triggers a restart of the etcd member after updating etcd's advertise peer URLs if found updated.

Introduced a CLI flag `--use-etcd-wrapper` (default: false) to enable/disable the backup-restore to use etcd-wrapper related functionality. Note: enable this flag only if etcd-wrapper is deployed.

Added a capability to stop the etcd-wrapper container by exposing an endpoint `/stop`. 

Upgrade the Go dependency to `go1.23.1`.

ops/print-etcd-cert-paths.sh has been removed and is now replaced with ops/print-etcd-cheatsheet.sh

@unmarshall @shreyas-s-rao
Fixes Label-Selector, Pod Template label updates and TLS changes for …
460f309 
…client and peer communication (gardener#883)

* fixes gardener#881, gardener#877
* Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23
* Added use-etcd-wrapper cli arg for etcdbr container
* removed etcd-cluster-size label to be added later with ability to restore while keep etcd.spec.replicas > 1
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner October 23, 2024 13:27
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Oct 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 23, 2024
ishan16696
ishan16696 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

unmarshall
unmarshall approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
@shreyas-s-rao shreyas-s-rao merged commit fa13ba7 into gardener:hotfix-v0.23 Oct 23, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 23, 2024
@shreyas-s-rao shreyas-s-rao deleted the v0.23.1/cherry-pick-pr-883 branch October 23, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

@ishan16696 ishan16696 ishan16696 approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shreyas-s-rao @unmarshall @ishan16696 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot