Revert "[ci:component:github.com/gardener/terraformer:v2.5.0->v2.6.0]" #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
/invite @rfranzke @timebertt |
gardener-robot-ci-2
added
needs/ok-to-test
timebertt
approved these changes
May 7, 2021
There was a problem hiding this comment.
/lgtm
Just for my understanding: do you also plan to revert gardener/terraformer#91 or what fix do you have in mind?
gardener-robot
added
reviewed/lgtm
I don't want to revert it to the old version again. When the issue is fix from Alicloud, I will update the it to the newer version. |
rfranzke
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #277
With TF provider of version >=1.119 , one new field named
enable_ipv6would be added into the VPC resource, which will trigger a force replacement. It only impacts the VPC which has already been existing for a long time.It its blocking the release of extension-provider-alicloud, so revert the change and will restore it when the issue is fixed.