Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade tf-provider alicloud #91

Merged
merged 1 commit into from
Apr 26, 2021
Merged

upgrade tf-provider alicloud #91

merged 1 commit into from
Apr 26, 2021

Conversation

minchaow
Copy link
Contributor

How to categorize this PR?

/area open-source
/kind enhancement
/priority normal

What this PR does / why we need it:
This PR is to upgrade terraform provider version to 1.121.2.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Terraform provider of Alicloud is upgraded to 1.121.2.

@minchaow minchaow requested a review from a team as a code owner April 23, 2021 10:17
@gardener-robot
Copy link

@minchaow Label priority/normal does not exist.

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 23, 2021
@minchaow
Copy link
Contributor Author

/invite @jia-jerry

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 23, 2021
rfranzke
rfranzke reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rebase

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Apr 26, 2021
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Apr 26, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 26, 2021
@minchaow minchaow requested a review from rfranzke April 26, 2021 06:39
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 26, 2021
rfranzke
rfranzke approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 26, 2021
@rfranzke rfranzke merged commit b2d092f into gardener:master Apr 26, 2021
@minchaow minchaow mentioned this pull request May 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@jia-jerry jia-jerry Awaiting requested review from jia-jerry

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@minchaow @gardener-robot @rfranzke @gardener-robot-ci-3