-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infrastructure ConfigValidator for checking VPC IDs #395
Conversation
/invite @ialidzhikov @rfranzke @kon-angelo |
/squash |
/test |
Testrun: e2e-pvr8q +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | dnsrecord-test | dnsrecord-test | Succeeded | 7m37s | | infrastructure-test | infrastructure-test | Failed | 15m19s | | bastion-test | bastion-test | Succeeded | 5m0s | +---------------------+---------------------+-----------+----------+ |
/test |
Testrun: e2e-44xs2 +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Failed | 15m52s | | bastion-test | bastion-test | Succeeded | 5m17s | | dnsrecord-test | dnsrecord-test | Succeeded | 10m19s | +---------------------+---------------------+-----------+----------+ |
30cedd4
to
fe581cc
Compare
/test |
Testrun: e2e-jt7bc +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 15m16s | | bastion-test | bastion-test | Succeeded | 5m24s | | dnsrecord-test | dnsrecord-test | Succeeded | 6m13s | +---------------------+---------------------+-----------+----------+ |
@rfranzke, @kon-angelo You have pull request review open invite, please check |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
func ignoreNotFound(err error) error { | ||
if err == nil { | ||
return nil | ||
func IsNotFoundError(err error) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: doc string missing
Let's reopen this PR or have a new one and have it in after the release of v1.28.0 (as we did a revert with 8f00f94). |
How to categorize this PR?
/area ops-productivity
/area quality
/kind bug
/platform aws
What this PR does / why we need it:
infrastructure.ConfigValidator
for checking if a VPC ID exists, has correct VPC attribute values, and have an internet gateway attached. See Add infrastructure config validator gardener#4547.infrastructure.ConfigValidator
implementation (in a separate commit).Which issue(s) this PR fixes:
Special notes for your reviewer:
Release note: