Add infrastructure ConfigValidator for checking VPC IDs #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
/invite @ialidzhikov @rfranzke @kon-angelo |
stoyanr
changed the title
|
/squash |
gardener-robot-ci-3
added
needs/ok-to-test
|
/test |
|
Testrun: e2e-pvr8q +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | dnsrecord-test | dnsrecord-test | Succeeded | 7m37s | | infrastructure-test | infrastructure-test | Failed | 15m19s | | bastion-test | bastion-test | Succeeded | 5m0s | +---------------------+---------------------+-----------+----------+ |
|
/test |
|
Testrun: e2e-44xs2 +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Failed | 15m52s | | bastion-test | bastion-test | Succeeded | 5m17s | | dnsrecord-test | dnsrecord-test | Succeeded | 10m19s | +---------------------+---------------------+-----------+----------+ |
stoyanr
force-pushed
the
add-infra-config-validator
branch
from
30cedd4
to
fe581cc
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-jt7bc +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 15m16s | | bastion-test | bastion-test | Succeeded | 5m24s | | dnsrecord-test | dnsrecord-test | Succeeded | 6m13s | +---------------------+---------------------+-----------+----------+ |
|
@rfranzke, @kon-angelo You have pull request review open invite, please check |
|
/hold |
gardener-robot
added
the
reviewed/do-not-merge
rfranzke
approved these changes
Aug 30, 2021
| func ignoreNotFound(err error) error { | ||
| if err == nil { | ||
| return nil | ||
| func IsNotFoundError(err error) bool { |
gardener-robot
added
needs/lgtm
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-provider-aws
that referenced
this pull request
Aug 31, 2021
stoyanr
pushed a commit
that referenced
this pull request
Aug 31, 2021
|
Let's reopen this PR or have a new one and have it in after the release of v1.28.0 (as we did a revert with 8f00f94). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area ops-productivity
/area quality
/kind bug
/platform aws
What this PR does / why we need it:
infrastructure.ConfigValidatorfor checking if a VPC ID exists, has correct VPC attribute values, and have an internet gateway attached. See Add infrastructure config validator gardener#4547.infrastructure.ConfigValidatorimplementation (in a separate commit).Which issue(s) this PR fixes:
Special notes for your reviewer:
Release note: