-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infrastructure ConfigValidator for checking NAT IPs #312
Conversation
@stoyanr Labels area/todo, kind/todo do not exist. |
/invite @ialidzhikov |
1b4cbde
to
67b24a4
Compare
@kon-angelo Thanks for your comments, addressed them and also added some unit tests. |
/squash |
/test |
Testrun: e2e-7mwxl +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 9m45s | +---------------------+---------------------+-----------+----------+ |
67b24a4
to
050b39e
Compare
/test |
Testrun: e2e-vvlzm +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 10m30s | +---------------------+---------------------+-----------+----------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area ops-productivity
/area quality
/kind bug
/platform gcp
What this PR does / why we need it:
infrastructure.ConfigValidator
for checking whether NAT IP names refer to existing and available external IP addresses. See Add infrastructure config validator gardener#4547.infrastructure.ConfigValidator
implementation.Which issue(s) this PR fixes:
Fixes #309
Special notes for your reviewer:
Release note: