Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraformer to v2.13.0, a version that uses terraform 0.13 #439

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Nov 4, 2021

How to categorize this PR?

/area control-plane
/kind enhancement
/platform aws

What this PR does / why we need it:
Upgrades terraformer image to v2.13.0, a version that uses terraform 0.13.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release Notes:

terraform has been upgraded to 0.13.7

@stoyanr stoyanr requested review from a team as code owners November 4, 2021 13:03
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 4, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 4, 2021
@stoyanr stoyanr marked this pull request as draft November 4, 2021 13:04
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 4, 2021
@stoyanr
Copy link
Contributor Author

stoyanr commented Nov 4, 2021

/test

@testmachinery
Copy link

testmachinery bot commented Nov 4, 2021

Testrun: e2e-5q5hw
Workflow: e2e-5q5hw-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 15m59s   |
| bastion-test        | bastion-test        | Succeeded | 4m57s    |
| dnsrecord-test      | dnsrecord-test      | Succeeded | 6m54s    |
+---------------------+---------------------+-----------+----------+

@rfranzke
Copy link
Member

rfranzke commented Nov 4, 2021

Does this also work for existing shoots? https://www.terraform.io/upgrade-guides/0-13.html#in-house-providers talks about some state migration and a new terraform state replace-provider command that should be called?

@stoyanr
Copy link
Contributor Author

stoyanr commented Nov 4, 2021

Does this also work for existing shoots? https://www.terraform.io/upgrade-guides/0-13.html#in-house-providers talks about some state migration and a new terraform state replace-provider command that should be called?

I am currently in the process of testing and fixing this (hence Draft). As a matter of fact, it doesn't work even with the non-inhouse providers, the terraform state replace-provider command is needed there as well.

@stoyanr stoyanr force-pushed the upgrade-terraformer-terraform-0.13 branch from 08fb94c to fb48ce4 Compare November 5, 2021 10:02
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2021
@stoyanr
Copy link
Contributor Author

stoyanr commented Nov 5, 2021

/test

@testmachinery
Copy link

testmachinery bot commented Nov 5, 2021

Testrun: e2e-8sxfp
Workflow: e2e-8sxfp-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 15m48s   |
| bastion-test        | bastion-test        | Succeeded | 5m5s     |
| dnsrecord-test      | dnsrecord-test      | Succeeded | 7m1s     |
+---------------------+---------------------+-----------+----------+

@stoyanr stoyanr force-pushed the upgrade-terraformer-terraform-0.13 branch from fb48ce4 to 779bed1 Compare November 8, 2021 13:37
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2021
@ialidzhikov
Copy link
Member

ialidzhikov commented Nov 19, 2021

/hold
as we want to tackle few existing terraform issues for AWS before the update to terraform@0.13

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Nov 19, 2021
@stoyanr stoyanr changed the title Upgrade terraformer to a version that uses terraform 0.13 Upgrade terraformer to v2.13.0, a version that uses terraform 0.13 Nov 19, 2021
@stoyanr stoyanr marked this pull request as ready for review November 19, 2021 15:57
@stoyanr
Copy link
Contributor Author

stoyanr commented Nov 19, 2021

/invite @ialidzhikov @dkistner

The new terraform version has already been tested with AWS, see gardener/terraformer#105 for more details.

@stoyanr stoyanr force-pushed the upgrade-terraformer-terraform-0.13 branch from 779bed1 to b360ee7 Compare November 19, 2021 16:04
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 19, 2021
@stoyanr
Copy link
Contributor Author

stoyanr commented Nov 19, 2021

/test

@testmachinery
Copy link

testmachinery bot commented Nov 19, 2021

Testrun: e2e-2gkps
Workflow: e2e-2gkps-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 15m5s    |
| bastion-test        | bastion-test        | Succeeded | 5m36s    |
| dnsrecord-test      | dnsrecord-test      | Succeeded | 7m6s     |
+---------------------+---------------------+-----------+----------+

@stoyanr stoyanr force-pushed the upgrade-terraformer-terraform-0.13 branch from b360ee7 to 1d2ca21 Compare December 20, 2021 09:59
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 20, 2021
@ialidzhikov
Copy link
Member

/unhold

As the issues mentioned in #439 (comment) are now mitigated/fixed.

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Dec 20, 2021
@stoyanr
Copy link
Contributor Author

stoyanr commented Dec 20, 2021

/test

@testmachinery
Copy link

testmachinery bot commented Dec 20, 2021

Testrun: e2e-rd966
Workflow: e2e-rd966-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 15m40s   |
| bastion-test        | bastion-test        | Succeeded | 5m10s    |
| dnsrecord-test      | dnsrecord-test      | Failed    | 4m41s    |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 20, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 20, 2021
@stoyanr
Copy link
Contributor Author

stoyanr commented Dec 20, 2021

/test

@testmachinery
Copy link

testmachinery bot commented Dec 20, 2021

Testrun: e2e-tprb5
Workflow: e2e-tprb5-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 15m17s   |
| bastion-test        | bastion-test        | Succeeded | 5m7s     |
| dnsrecord-test      | dnsrecord-test      | Succeeded | 7m3s     |
+---------------------+---------------------+-----------+----------+

Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 21, 2021
@stoyanr stoyanr merged commit f77668d into gardener:master Dec 21, 2021
@stoyanr stoyanr deleted the upgrade-terraformer-terraform-0.13 branch December 21, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants