-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade terraformer to v2.13.0, a version that uses terraform 0.13 #439
Upgrade terraformer to v2.13.0, a version that uses terraform 0.13 #439
Conversation
/test |
Testrun: e2e-5q5hw +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 15m59s | | bastion-test | bastion-test | Succeeded | 4m57s | | dnsrecord-test | dnsrecord-test | Succeeded | 6m54s | +---------------------+---------------------+-----------+----------+ |
Does this also work for existing shoots? https://www.terraform.io/upgrade-guides/0-13.html#in-house-providers talks about some state migration and a new |
I am currently in the process of testing and fixing this (hence |
08fb94c
to
fb48ce4
Compare
/test |
Testrun: e2e-8sxfp +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 15m48s | | bastion-test | bastion-test | Succeeded | 5m5s | | dnsrecord-test | dnsrecord-test | Succeeded | 7m1s | +---------------------+---------------------+-----------+----------+ |
fb48ce4
to
779bed1
Compare
/hold |
/invite @ialidzhikov @dkistner The new terraform version has already been tested with AWS, see gardener/terraformer#105 for more details. |
779bed1
to
b360ee7
Compare
/test |
Testrun: e2e-2gkps +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 15m5s | | bastion-test | bastion-test | Succeeded | 5m36s | | dnsrecord-test | dnsrecord-test | Succeeded | 7m6s | +---------------------+---------------------+-----------+----------+ |
b360ee7
to
1d2ca21
Compare
/unhold As the issues mentioned in #439 (comment) are now mitigated/fixed. |
/test |
Testrun: e2e-rd966 +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 15m40s | | bastion-test | bastion-test | Succeeded | 5m10s | | dnsrecord-test | dnsrecord-test | Failed | 4m41s | +---------------------+---------------------+-----------+----------+ |
/test |
Testrun: e2e-tprb5 +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 15m17s | | bastion-test | bastion-test | Succeeded | 5m7s | | dnsrecord-test | dnsrecord-test | Succeeded | 7m3s | +---------------------+---------------------+-----------+----------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area control-plane
/kind enhancement
/platform aws
What this PR does / why we need it:
Upgrades
terraformer
image to v2.13.0, a version that usesterraform
0.13.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release Notes: