-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade terraform to 0.13.7 #105
Conversation
/invite @ialidzhikov |
abec510
to
1136745
Compare
1136745
to
c7a9b03
Compare
c7a9b03
to
acc2afa
Compare
acc2afa
to
26820af
Compare
Provider validation status: AWS (see gardener/gardener-extension-provider-aws/pull/439):
GCP (see gardener/gardener-extension-provider-gcp/pull/345):
Azure (see gardener/gardener-extension-provider-azure/pull/391):
Alicloud (see gardener/gardener-extension-provider-alicloud/pull/379):
Openstack (see gardener/gardener-extension-provider-openstack/pull/350):
|
We had a sync with @stoyanr on how to proceed with the terraform version updates. We agreed to proceed first with the 0.13.7 update and to have a new terraformer minor release with it ( Last but not least, many thanks to @stoyanr for his work on this topic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general. I managed to test the following scenarios with gardener-extension-provider-aws and they worked well:
- reconciliation of existing Infrastructure
- deletion of existing Infrastructure
- creation and deletion of new Infrastructure (single zone, new vpc)
- creation and deletion of new Infrastructure (multiple zones, new vpc)
- creation and deletion of new Infrastructure (single zone, existing vpc)
- creation and deletion of new Infrastructure (multiple zone, existing vpc)
@ialidzhikov I added the tests as requested and replied to your other comments, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
Upgrades terraform to 0.13.7. This is the first step of upgrading to 0.15 in order to fix gardener/gardener/issues/4838.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
make test-e2e
andmake docker-images
locally.make start
andmake start COMMAND=destroy
with a valid AWS configuration for one of my test shoots.Release note: