-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable controlplane/network webhook mutation for "no overlay" #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
Control plane related
kind/bug
Bug
platform/aws
Amazon web services platform/infrastructure
needs/review
Needs review
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
labels
Sep 27, 2022
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 27, 2022
/hold |
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Sep 27, 2022
gardener-robot
added
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Sep 27, 2022
/unhold |
gardener-robot
removed
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Sep 27, 2022
/priority critical |
gardener-robot
added
the
priority/critical
Needs to be resolved soon, because it impacts users negatively
label
Sep 27, 2022
dkistner
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
labels
Sep 27, 2022
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Sep 27, 2022
kon-angelo
added a commit
that referenced
this pull request
Sep 28, 2022
…etwork webhook mutation for "no overlay" (#623) * Revert "Enable custom aws route controller manager if no provider config is specified." This reverts commit f28fe0d. * Revert "Enable custom aws route controller per default for kubernetes >= 1.22 unless explicitly disabled." This reverts commit 0b874a6. * Revert "Create shoot cluster per default without overlay network for kubernetes >= 1.22." This reverts commit 0262b79.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/control-plane
Control plane related
kind/bug
Bug
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
platform/aws
Amazon web services platform/infrastructure
priority/critical
Needs to be resolved soon, because it impacts users negatively
reviewed/lgtm
Has approval for merging
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
/platform aws
What this PR does / why we need it:
Disable automatic enablement of no-overlay network configuration for cluster >=1.22
Which issue(s) this PR fixes:
Fixes #619
Fixes #621
Special notes for your reviewer:
Release note: