Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable controlplane/network webhook mutation for "no overlay" #622

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Disable controlplane/network webhook mutation for "no overlay" #622

merged 3 commits into from
Sep 27, 2022

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Sep 27, 2022 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area control-plane
/kind bug
/platform aws

What this PR does / why we need it:
Disable automatic enablement of no-overlay network configuration for cluster >=1.22

Which issue(s) this PR fixes:
Fixes #619
Fixes #621

Special notes for your reviewer:

Release note:

Disable automatic enablement of no-overlay network configuration for cluster >=1.22

@kon-angelo kon-angelo requested review from a team as code owners September 27, 2022 13:53
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug platform/aws Amazon web services platform/infrastructure needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 27, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2022
@kon-angelo
Copy link
Contributor Author

/hold

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2022
@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Sep 27, 2022
@kon-angelo
Copy link
Contributor Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Sep 27, 2022
@kon-angelo
Copy link
Contributor Author

/priority critical

@gardener-robot gardener-robot added the priority/critical Needs to be resolved soon, because it impacts users negatively label Sep 27, 2022
dkistner
dkistner approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Sep 27, 2022
@kon-angelo kon-angelo merged commit 68d1371 into gardener:master Sep 27, 2022
@kon-angelo kon-angelo deleted the fix/cp-webhook-crc2 branch September 27, 2022 15:12
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 27, 2022
@kon-angelo kon-angelo mentioned this pull request Sep 27, 2022
Merged
kon-angelo added a commit that referenced this pull request Sep 28, 2022
@kon-angelo
[release-v1.38] Automated cherry pick of #622: Disable controlplane/n…
344dde9 
…etwork webhook mutation for "no overlay" (#623)

* Revert "Enable custom aws route controller manager if no provider config is specified."

This reverts commit f28fe0d.

* Revert "Enable custom aws route controller per default for kubernetes >= 1.22 unless explicitly disabled."

This reverts commit 0b874a6.

* Revert "Create shoot cluster per default without overlay network for kubernetes >= 1.22."

This reverts commit 0262b79.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure priority/critical Needs to be resolved soon, because it impacts users negatively reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
4 participants
@kon-angelo @dkistner @gardener-robot-ci-3 @gardener-robot