Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.38] Automated cherry pick of #622: Disable controlplane/network webhook mutation for "no overlay" #623

Merged
merged 3 commits into from
Sep 28, 2022
Merged

[release-v1.38] Automated cherry pick of #622: Disable controlplane/network webhook mutation for "no overlay" #623

merged 3 commits into from
Sep 28, 2022

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Sep 27, 2022 •
edited by ialidzhikov
Loading

/area/control-plane
/kind/bug

Cherry pick of #622 on release-v1.38.

#622: Disable controlplane/network webhook mutation for "no overlay"

Release Notes:

Disable automatic enablement of no-overlay network configuration for cluster >=1.22

@kon-angelo kon-angelo requested review from a team as code owners September 27, 2022 15:19
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 27, 2022
@kon-angelo
Copy link
Contributor Author

/hold

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2022
@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Sep 27, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2022
@kon-angelo
Copy link
Contributor Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Sep 28, 2022
ialidzhikov
ialidzhikov approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Sep 28, 2022
@kon-angelo kon-angelo merged commit 344dde9 into gardener:release-v1.38 Sep 28, 2022
@kon-angelo kon-angelo deleted the automated-cherry-pick-of-#622-origin-release-v1.38 branch September 28, 2022 09:22
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kon-angelo @ialidzhikov @gardener-robot-ci-3 @gardener-robot