Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain fault and update domain counts #111

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Retain fault and update domain counts #111

merged 2 commits into from
Jun 17, 2020

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Jun 16, 2020 •
edited
Loading

How to categorize this PR?

/area quality
/kind bug
/priority normal
/platform azure

What this PR does / why we need it:
The PR retains the fault and update domain counts for the worker availability set instead of always taking the configured value from the cloud profile.

Which issue(s) this PR fixes:
Fixes #109

Special notes for your reviewer:
This PR needs gardener/gardener#2460 as a prerequisite. I will re-vendor g/g as soon as the PR is merged.
✅ Bumped to g/g v1.6.2

Release note:

An issue has been fixed which caused a reconcile error for the infrastructure if the `countFaultDomains` or `countUpdateDomains` values for the shoot's region was changed.

@timuthy timuthy requested review from a team as code owners June 16, 2020 13:19
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure priority/normal labels Jun 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 16, 2020
dkistner
dkistner previously approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the PR :)

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jun 16, 2020
rfranzke
rfranzke previously approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR!

pkg/internal/infrastructure/terraform.go Show resolved Hide resolved
pkg/internal/infrastructure/terraform.go Outdated Show resolved Hide resolved
@timuthy timuthy dismissed stale reviews from rfranzke and dkistner via 05219db June 17, 2020 07:19
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 17, 2020
@timuthy timuthy mentioned this pull request Jun 17, 2020
Merged
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 17, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 17, 2020
@rfranzke rfranzke merged commit d0d0c29 into gardener:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@dkistner dkistner dkistner left review comments

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infra failure when fault or update domain count is changed
6 participants
@timuthy @dkistner @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot