Be pessimistic about legacy cm deletion #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
timuthy
force-pushed
the
fix.cloud-provider-config
branch
from
2fe67b4 to
cd7f0ea
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
timuthy
changed the title
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
@danielfoehrKn Can you have look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
/priority normal
/platform azure
What this PR does / why we need it:
With the introduction of #99 we observed errors during the shoot deletion because the KAS deployment still referred to the legacy cloud-provider config map. This PR adds a check if the said config map is still referenced and skips the deletion. Please note that the deletion error only happens under special circumstances, e.g. if the shoot reconciliation is aborted after the control plane deployment and immediately deleted.
Special notes for your reviewer:
/cc @danielfoehrKn
Release note: