Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from cm to secret for cloud provider config #99

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Switch from cm to secret for cloud provider config #99

merged 1 commit into from
Jun 3, 2020

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented May 28, 2020

How to categorize this PR?

/area control-plane
/kind enhancement
/priority normal
/platform azure

What this PR does / why we need it:
This PR let's the extension create/use Secrets instead of ConfigMaps for cloud-provider-config and cloud-provider-disk-config.

Release note:

The Kubernetes Kind for `cloud-provider-config` and `cloud-provider-disk-config` in a shoot's control plane has been changed from ConfigMap to Secret.

@timuthy timuthy requested review from a team as code owners May 28, 2020 07:51
@ghost ghost added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension labels May 28, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 28, 2020
@ghost ghost added platform/azure Microsoft Azure platform/infrastructure priority/normal labels May 28, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 28, 2020
@timuthy timuthy force-pushed the enhancement.cp-secret branch from f0d32f7 to fe8139b Compare May 28, 2020 08:39
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 28, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 28, 2020
@timuthy timuthy force-pushed the enhancement.cp-secret branch from fe8139b to a662b2d Compare May 29, 2020 14:50
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 29, 2020
rfranzke
rfranzke reviewed Jun 2, 2020
View reviewed changes
@timuthy timuthy force-pushed the enhancement.cp-secret branch from a662b2d to 4ee2f41 Compare June 2, 2020 14:57
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2020
rfranzke
rfranzke approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jun 3, 2020
@timuthy timuthy merged commit 5a2055c into gardener:master Jun 3, 2020
@timuthy timuthy deleted the enhancement.cp-secret branch June 3, 2020 07:07
@timuthy timuthy mentioned this pull request Jul 9, 2020
Merged
@ialidzhikov ialidzhikov mentioned this pull request Nov 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timuthy @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot