Bump github.com/gardener/gardener to 1.86.0 #675

timuthy · 2023-12-19T22:12:04Z

How to categorize this PR?

/area open-source
/kind enhancement
/platform gcp

What this PR does / why we need it:
This PR updates the github.com/gardener/gardener dependency to v1.86.0. As a consequence, admission CA and service certificates are now managed automatically. The vendor directory is removed as well.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Bump github.com/gardener/gardener to 1.86.0.

CA and server certificates for the admission component are managed automatically. Passing custom certificates via Helm values is not supported anymore.

The `vendor` directory was removed in favor of the `go mod cache`.

gitguardian · 2023-12-19T22:12:40Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
-	RSA Private Key	`7b91753`	example/admission-gcp-certs/tls.key	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

gardener-robot · 2024-01-03T14:13:16Z

@timuthy You need rebase this pull request with latest master branch. Please check.

Since admission controllers now run the certificate controller, leader election must be enabled to prevent any interference.

This change is mostly relevant for deployments without a virtual Garden cluster: In this case, the admission controller needed cluster-wide list/watch permissions for secrets. Restricting the cache to the `--webhook-config-namespace` namespace eliminates this requirement.

Address review comments from similar PR gardener/gardener-extension-networking-calico#327.

kon-angelo

/lgtm

timuthy requested review from a team as code owners December 19, 2023 22:12

gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review labels Dec 19, 2023

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 19, 2023

gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Dec 19, 2023

gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 19, 2023

timuthy force-pushed the enh.gardener-v185 branch from 1642a62 to 2fdadf1 Compare December 21, 2023 06:26

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 21, 2023

timuthy force-pushed the enh.gardener-v185 branch from 2fdadf1 to b57a91b Compare December 21, 2023 08:37

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 21, 2023

timuthy force-pushed the enh.gardener-v185 branch from b57a91b to af12082 Compare January 3, 2024 14:12

gardener-robot added the needs/rebase Needs git rebase label Jan 3, 2024

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 3, 2024

timuthy force-pushed the enh.gardener-v185 branch from af12082 to 8706432 Compare January 3, 2024 14:38

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 3, 2024

timuthy force-pushed the enh.gardener-v185 branch from 8706432 to 0fe6c86 Compare January 4, 2024 07:52

timuthy changed the title ~~Bump github.com/gardener/gardener to 1.85.1~~ Bump github.com/gardener/gardener to 1.86.0 Jan 4, 2024

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 4, 2024

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 4, 2024

timuthy force-pushed the enh.gardener-v185 branch from 10d8b72 to ea8434f Compare January 9, 2024 07:28

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 9, 2024

timuthy added 11 commits January 16, 2024 16:00

Update github.com/gardener/gardener to v1.85.1

e4100a5

Remove vendor dir

d8eafcf

Adjust paths after vendor removal

65cf4de

[make tidy]

c3c1a55

[make generate]

d7e636e

Adjust admission webhook

7b91753

Enable leader election for admission controller

1446a89

Since admission controllers now run the certificate controller, leader election must be enabled to prevent any interference.

Update github.com/gardener/gardener to v1.86.0

e84a640

Address review comments

39de792

Address review comments from similar PR gardener/gardener-extension-networking-calico#327.

Replace hook-me with Make Target

4feca36

timuthy force-pushed the enh.gardener-v185 branch from 2874ebe to 4feca36 Compare January 16, 2024 15:23

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 16, 2024

kon-angelo approved these changes Jan 17, 2024

View reviewed changes

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 17, 2024

kon-angelo merged commit 69e27ab into gardener:master Jan 17, 2024
8 checks passed

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 17, 2024

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024

timuthy deleted the enh.gardener-v185 branch January 17, 2024 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump github.com/gardener/gardener to 1.86.0 #675

Bump github.com/gardener/gardener to 1.86.0 #675

timuthy commented Dec 19, 2023 •

edited

Loading

gitguardian bot commented Dec 19, 2023 •

edited

Loading

gardener-robot commented Jan 3, 2024

kon-angelo left a comment

Bump github.com/gardener/gardener to 1.86.0 #675

Bump github.com/gardener/gardener to 1.86.0 #675

Conversation

timuthy commented Dec 19, 2023 • edited Loading

gitguardian bot commented Dec 19, 2023 • edited Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

gardener-robot commented Jan 3, 2024

kon-angelo left a comment

Choose a reason for hiding this comment

timuthy commented Dec 19, 2023 •

edited

Loading

gitguardian bot commented Dec 19, 2023 •

edited

Loading