Bump github.com/gardener/gardener to 1.86.0 #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/open-source
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
size/xl
gardener-robot-ci-3
added
needs/ok-to-test
Since admission controllers now run the certificate controller, leader election must be enabled to prevent any interference.
timuthy
force-pushed
the
enh.gardener-v186
branch
from
1a2b35c to
a79f9db
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
ScheererJ
requested changes
Jan 9, 2024
|
Can you please adapt https://github.com/gardener/gardener-extension-networking-calico/blob/master/.github/workflows/vendor_gardener.yaml as well (revendor => tidy) similar to gardener/gardener-extension-shoot-networking-filter#111? |
gardener-robot-ci-1
added
reviewed/ok-to-test
timuthy
added a commit
to timuthy/gardener-extension-provider-gcp
that referenced
this pull request
Jan 10, 2024
Address review comments from similar PR gardener/gardener-extension-networking-calico#327.
timuthy
added a commit
to timuthy/gardener-extension-shoot-rsyslog-relp
that referenced
this pull request
Jan 10, 2024
Address review comment from similar PR gardener/gardener-extension-networking-calico#327.
timuthy
added a commit
to timuthy/gardener-extension-provider-openstack
that referenced
this pull request
Jan 10, 2024
Address review comments from similar PR gardener/gardener-extension-networking-calico#327.
timuthy
added a commit
to timuthy/gardener-extension-provider-azure
that referenced
this pull request
Jan 10, 2024
Address review comments from similar PR gardener/gardener-extension-networking-calico#327.
timuthy
added a commit
to timuthy/gardener-extension-provider-alicloud
that referenced
this pull request
Jan 10, 2024
Address review comments from similar PR gardener/gardener-extension-networking-calico#327.
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
gardener-robot-ci-3
added
the
reviewed/ok-to-test
kon-angelo
pushed a commit
to gardener/gardener-extension-provider-azure
that referenced
this pull request
Jan 16, 2024
* Update `github.com/gardener/gardener` to `v1.86.0` * Remove vendor dir * Adjust paths after vendor removal * [make tidy] * [make generate] * Adjust admission webhook * Enable leader election for admission controller Since admission controllers now run the certificate controller, leader election must be enabled to prevent any interference. * Restrict admission controller permissions This change is mostly relevant for deployments without a virtual Garden cluster: In this case, the admission controller needed cluster-wide list/watch permissions for secrets. Restricting the cache to the `--webhook-config-namespace` namespace eliminates this requirement. * Address review comments Address review comments from similar PR gardener/gardener-extension-networking-calico#327.
timuthy
added a commit
to timuthy/gardener-extension-provider-gcp
that referenced
this pull request
Jan 16, 2024
Address review comments from similar PR gardener/gardener-extension-networking-calico#327.
kon-angelo
pushed a commit
to gardener/gardener-extension-provider-gcp
that referenced
this pull request
Jan 17, 2024
* Update `github.com/gardener/gardener` to `v1.85.1` * Remove vendor dir * Adjust paths after vendor removal * [make tidy] * [make generate] * Adjust admission webhook * Enable leader election for admission controller Since admission controllers now run the certificate controller, leader election must be enabled to prevent any interference. * Update `github.com/gardener/gardener` to v1.86.0 * Restrict admission controller permissions This change is mostly relevant for deployments without a virtual Garden cluster: In this case, the admission controller needed cluster-wide list/watch permissions for secrets. Restricting the cache to the `--webhook-config-namespace` namespace eliminates this requirement. * Address review comments Address review comments from similar PR gardener/gardener-extension-networking-calico#327. * Replace hook-me with Make Target
kon-angelo
pushed a commit
to gardener/gardener-extension-provider-openstack
that referenced
this pull request
Jan 17, 2024
* Update `github.com/gardener/gardener` to `v1.86.0` * Remove vendor dir * Adjust paths after vendor removal * [make tidy] * [make generate] * Adjust admission webhook * Enable leader election for admission controller Since admission controllers now run the certificate controller, leader election must be enabled to prevent any interference. * Restrict admission controller permissions This change is mostly relevant for deployments without a virtual Garden cluster: In this case, the admission controller needed cluster-wide list/watch permissions for secrets. Restricting the cache to the `--webhook-config-namespace` namespace eliminates this requirement. * Address review comments Address review comments from similar PR gardener/gardener-extension-networking-calico#327. * fix typo in makefile * Replace hook-me with Make Target --------- Co-authored-by: Andreas Burger <andreas.burger@sap.com>
shaoyongfeng
pushed a commit
to gardener/gardener-extension-provider-alicloud
that referenced
this pull request
Feb 1, 2024
* Update `github.com/gardener/gardener` to `v1.83.2` * Push adjustments for v1.83.2 * [make generate] * Update `github.com/gardener/gardener` to `v1.86.0` * Remove vendor dir * Adjust paths after vendor removal * [make tidy] * [make generate] * Adjust admission webhook * Enable leader election for admission controller Since admission controllers now run the certificate controller, leader election must be enabled to prevent any interference. * Address review comments Address review comments from similar PR gardener/gardener-extension-networking-calico#327.
timuthy
added a commit
to timuthy/gardener-extension-shoot-rsyslog-relp
that referenced
this pull request
Feb 26, 2024
Address review comment from similar PR gardener/gardener-extension-networking-calico#327.
gardener-prow bot
pushed a commit
to gardener/gardener-extension-shoot-rsyslog-relp
that referenced
this pull request
Feb 27, 2024
* Update `github.com/gardener/gardener` to `v1.86.0` * Remove vendor dir * Adjust paths after vendor removal * [make tidy] * [make generate] * Adjust admission webhook * Enable leader election for admission controller Since admission controllers now run the certificate controller, leader election must be enabled to prevent any interference. * Remove namespace optimization The admission controller works with secrets from other namespaces. A restriction is not possible at this point. * Always set `to-runtime-apiserver` label This label is required because TLS secrets reside in the runtime cluster. * Address review comment Address review comment from similar PR gardener/gardener-extension-networking-calico#327. * Address review comments II
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind enhancement
What this PR does / why we need it:
This PR updates the
github.com/gardener/gardenerdependency tov1.86.0. As a consequence, admission CA and service certificates are now managed automatically. The vendor directory is removed as well.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: