Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/gardener/gardener to 1.86.0 #57

Merged
merged 11 commits into from
Feb 27, 2024

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Jan 5, 2024

How to categorize this PR?

/area open-source
/kind enhancement
What this PR does / why we need it:
This PR updates the github.com/gardener/gardener dependency to v1.86.0. As a consequence, admission CA and service certificates are now managed automatically. The vendor directory is removed as well.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Bump github.com/gardener/gardener to 1.86.0.
CA and server certificates for the admission component are managed automatically. Passing custom certificates via Helm values is not supported anymore.
The `vendor` directory was removed in favor of the `go mod cache`.

@gardener-prow gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Jan 5, 2024
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/review labels Jan 5, 2024
@gardener-robot gardener-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion labels Jan 5, 2024
@timuthy timuthy force-pushed the enh.gardener-v186 branch from a085b14 to 1acb02c Compare January 5, 2024 11:21
@timuthy timuthy force-pushed the enh.gardener-v186 branch from 1acb02c to 1260346 Compare January 5, 2024 12:00
@timuthy timuthy force-pushed the enh.gardener-v186 branch from 1260346 to 7deb5ab Compare January 5, 2024 12:13
@timuthy timuthy force-pushed the enh.gardener-v186 branch from 7deb5ab to fc3ceb3 Compare January 5, 2024 12:54
@timuthy timuthy force-pushed the enh.gardener-v186 branch from bf4294a to 23a6593 Compare January 5, 2024 15:57
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
@timuthy timuthy force-pushed the enh.gardener-v186 branch from 23a6593 to f5283a9 Compare January 8, 2024 15:54
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2024
Since admission controllers now run the certificate controller, leader election must be enabled to prevent any interference.
The admission controller works with secrets from other namespaces. A restriction is not possible at this point.
This label is required because TLS secrets reside in the runtime cluster.
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2024
@gardener-prow gardener-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 26, 2024
@plkokanov
Copy link
Collaborator

🚀
/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
Copy link

gardener-prow bot commented Feb 27, 2024

LGTM label has been added.

Git tree hash: 66f8f8c493b26accee5af3408cf3d07ca88e90cf

Copy link

gardener-prow bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: plkokanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@gardener-prow gardener-prow bot merged commit 7cd4097 into gardener:main Feb 27, 2024
7 checks passed
@timuthy timuthy deleted the enh.gardener-v186 branch February 27, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants