Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support shoot access restriction configurations in CloudProfile, Seed, and Shoot APIs #10654

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Support shoot access restriction configurations in CloudProfile, Seed, and Shoot APIs #10654

merged 9 commits into from
Oct 18, 2024

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Oct 15, 2024 •
edited
Loading

How to categorize this PR?

/area usability
/kind api-change
/kind enhancement

What this PR does / why we need it:

This PR introduces dedicated fields to configure access restrictions in the APIs of CloudProfile, Seed, and Shoot based on https://github.com/gardener/dashboard/blob/master/docs/operations/access-restrictions.md#access-restrictions.

Currently, Gardener does not know about this feature, and it is solely implement in the Dashboard as well as gardenctl, which comes with certain limitations, see gardener/dashboard#2120 (comment).

Read https://github.com/rfranzke/gardener/blob/access-restrictions/docs/usage/shoot/access_restrictions.md to learn what has been implemented as part of this PR.

Which issue(s) this PR fixes:
Follow-up of #2340
Part of gardener/dashboard#2120

Special notes for your reviewer:
/cc @grolu @petersutter

Release note:

The `CloudProfile`, `Seed`, and `Shoot` APIs are now allowing to configure access restrictions (e.g., to enable "EU access"-only or similar policies). The legacy approach with the `seed.gardener.cloud/eu-access` labels is deprecated and will be removed in a future release. Make sure to adapt to the new APIs. Read all about it [here](https://github.com/gardener/gardener/tree/master/docs/usage/shoot/access_restrictions.md).

@gardener-prow gardener-prow bot added area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Oct 15, 2024
@rfranzke rfranzke mentioned this pull request Oct 15, 2024
Open
3 tasks
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 15, 2024
@rfranzke rfranzke changed the title Access restrictions Support access restriction configurations in CloudProfile, Seed, and Shoot APIs Oct 15, 2024
@rfranzke rfranzke changed the title Support access restriction configurations in CloudProfile, Seed, and Shoot APIs Support shoot access restriction configurations in CloudProfile, Seed, and Shoot APIs Oct 15, 2024
@Kostov6
Copy link
Contributor

Kostov6 commented Oct 16, 2024

/assign

shafeeqes
shafeeqes reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the well structured PR.

docs/usage/shoot/access_restrictions.md Outdated Show resolved Hide resolved
pkg/apis/core/types_shoot.go Outdated Show resolved Hide resolved
pkg/apis/core/v1beta1/types_shoot.go Outdated Show resolved Hide resolved
pkg/apiserver/registry/core/cloudprofile/strategy.go Outdated Show resolved Hide resolved
pkg/apiserver/registry/core/shoot/strategy_test.go Outdated Show resolved Hide resolved
LucaBernstein
LucaBernstein reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@LucaBernstein LucaBernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, lgtm, only saw some minor doc spelling issues...

pkg/apis/core/types_seed.go Outdated Show resolved Hide resolved
pkg/apis/core/v1beta1/types_seed.go Outdated Show resolved Hide resolved
pkg/apis/core/v1beta1/types_cloudprofile.go Outdated Show resolved Hide resolved
LucaBernstein
LucaBernstein reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@LucaBernstein LucaBernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Oct 16, 2024

LGTM label has been added.

Git tree hash: 05bff3906d67452d8f0cfa44f4394c0c6b85fdea

@shafeeqes
Copy link
Contributor

/lgtm

@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Oct 16, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Oct 16, 2024
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2024
petersutter
petersutter approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Oct 18, 2024

LGTM label has been added.

Git tree hash: 9f5fc42af6cfab4b4238e255965883018f6edb22

@rfranzke
Copy link
Member Author

/approve

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petersutter, rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@gardener-prow gardener-prow bot merged commit ab89d09 into gardener:master Oct 18, 2024
19 checks passed
@rfranzke rfranzke deleted the access-restrictions branch October 18, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@grolu grolu Awaiting requested review from grolu

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

@Kostov6 Kostov6 Awaiting requested review from Kostov6

@LucaBernstein LucaBernstein Awaiting requested review from LucaBernstein

Assignees

@petersutter petersutter

@Kostov6 Kostov6

@LucaBernstein LucaBernstein

@shafeeqes shafeeqes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfranzke @Kostov6 @shafeeqes @petersutter @LucaBernstein