-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support shoot access restriction configurations in CloudProfile
, Seed
, and Shoot
APIs
#10654
Conversation
CloudProfile
, Seed
, and Shoot
APIs
CloudProfile
, Seed
, and Shoot
APIs CloudProfile
, Seed
, and Shoot
APIs
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the well structured PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, lgtm, only saw some minor doc spelling issues...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 05bff3906d67452d8f0cfa44f4394c0c6b85fdea
|
/lgtm |
3f7d022
to
b34e337
Compare
b34e337
to
148d998
Compare
148d998
to
654fc40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 9f5fc42af6cfab4b4238e255965883018f6edb22
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petersutter, rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area usability
/kind api-change
/kind enhancement
What this PR does / why we need it:
This PR introduces dedicated fields to configure access restrictions in the APIs of
CloudProfile
,Seed
, andShoot
based on https://github.com/gardener/dashboard/blob/master/docs/operations/access-restrictions.md#access-restrictions.Currently, Gardener does not know about this feature, and it is solely implement in the Dashboard as well as
gardenctl
, which comes with certain limitations, see gardener/dashboard#2120 (comment).Read https://github.com/rfranzke/gardener/blob/access-restrictions/docs/usage/shoot/access_restrictions.md to learn what has been implemented as part of this PR.
Which issue(s) this PR fixes:
Follow-up of #2340
Part of gardener/dashboard#2120
Special notes for your reviewer:
/cc @grolu @petersutter
Release note: