Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seedSelector for shoot scheduling decisions #2340

Merged
merged 1 commit into from
May 19, 2020
Merged

Add seedSelector for shoot scheduling decisions #2340

merged 1 commit into from
May 19, 2020

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented May 18, 2020 •
edited
Loading

What this PR does / why we need it:
This PR adds a .spec.seedSelector field for Shoots (similar to the .spec.nodeSelector for Pods).
Also, it allows to configure arbitrary labels per region in the CloudProfile's .spec.regions[] list.

Which issue(s) this PR fixes:
Fixes #2306

Release note:

It is now possible to add arbitrary labels to the `.spec.regions[].labels` field in the `CloudProfile`, e.g. to provide more information about reliability, access restrictions, etc.

The `Shoot` specification does now have a new `.spec.seedSelector` field which allows to provide label selector. Only seeds whose labels match will be considered for scheduling decisions.

How to categorize this PR?

/area usability
/kind api-change
/kind enhancement
/priority normal

@rfranzke rfranzke requested a review from a team as a code owner May 18, 2020 03:58
@ghost ghost added area/usability Usability related kind/enhancement Enhancement, improvement, extension priority/normal labels May 18, 2020
@ghost ghost added the kind/api-change API change with impact on API users label May 18, 2020
@timebertt
Copy link
Member

/assign

@ghost ghost assigned timebertt May 19, 2020
timebertt
timebertt reviewed May 19, 2020
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice:)
Only minor comments from my side.

docs/concepts/scheduler.md Outdated Show resolved Hide resolved
docs/concepts/scheduler.md Show resolved Hide resolved
pkg/scheduler/controller/shoot/scheduler_control.go Show resolved Hide resolved
@rfranzke rfranzke requested a review from timebertt May 19, 2020 07:37
@petersutter petersutter mentioned this pull request May 19, 2020
Merged
@rfranzke rfranzke merged commit 5e7b048 into gardener:master May 19, 2020
@rfranzke rfranzke deleted the feature/seedselector branch May 19, 2020 15:56
@petersutter petersutter mentioned this pull request Jul 27, 2020
Closed
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
@rfranzke rfranzke mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt approved these changes

Assignees

@timebertt timebertt

Labels
area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.spec.seedSelector for Shoot resources
6 participants
@rfranzke @timebertt @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot