-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seedSelector for shoot scheduling decisions #2340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area/usability
Usability related
kind/enhancement
Enhancement, improvement, extension
priority/normal
labels
May 18, 2020
rfranzke
force-pushed
the
feature/seedselector
branch
from
May 18, 2020 15:00
14e5bd2
to
ceed7e3
Compare
/assign |
ghost
assigned timebertt
May 19, 2020
timebertt
reviewed
May 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice:)
Only minor comments from my side.
rfranzke
force-pushed
the
feature/seedselector
branch
from
May 19, 2020 07:35
ceed7e3
to
0857a48
Compare
timebertt
approved these changes
May 19, 2020
gardener-robot
added
priority/3
Priority (lower number equals higher priority)
and removed
priority/3
Priority (lower number equals higher priority)
labels
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/usability
Usability related
kind/api-change
API change with impact on API users
kind/enhancement
Enhancement, improvement, extension
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a
.spec.seedSelector
field forShoot
s (similar to the.spec.nodeSelector
forPod
s).Also, it allows to configure arbitrary labels per region in the
CloudProfile
's.spec.regions[]
list.Which issue(s) this PR fixes:
Fixes #2306
Release note:
How to categorize this PR?
/area usability
/kind api-change
/kind enhancement
/priority normal